From: Christoph Hellwig <hch@infradead.org>
To: Tonnerre <tonnerre@thundrix.ch>
Cc: Christoph Hellwig <hch@infradead.org>,
Antony Suter <suterant@users.sourceforge.net>,
List LKML <linux-kernel@vger.kernel.org>,
torvalds@osdl.org
Subject: Re: [PATCH] __VMALLOC_RESERVE export
Date: Mon, 27 Sep 2004 21:15:04 +0100 [thread overview]
Message-ID: <20040927211504.A27577@infradead.org> (raw)
In-Reply-To: <20040927195510.GD17487@thundrix.ch>; from tonnerre@thundrix.ch on Mon, Sep 27, 2004 at 09:55:10PM +0200
> On Mon, Sep 27, 2004 at 06:12:29PM +0100, Christoph Hellwig wrote:
> > On Tue, Sep 28, 2004 at 03:03:43AM +1000, Antony Suter wrote:
> > > __VMALLOC_RESERVE itself is not exported but is used by something that
> > > is. This patch is against 2.6.9-rc2-bk11
> > >
> > > This is required by the nvidia binary driver 1.0.6111
> >
> > And the driver does absolutely nasty things it shouldn't do. This is an
> > implementation detail that absolutely should not be exported.
>
> NVidia isn't the only user...
>
> Every kernel module that uses just anything that uses the old
> __VMALLOC_RESERVE define was broken without this patch.
NVidia doesn't have a monopoly on crappy drivers, news at eleven..
__VMALLOC_RESERVE/VMALLOC_RESERVE is only used either in arch/i386 or
defined to MAXMEM whichs is also not used outside of arch/{i386,x86_64,mips}.
Doesn't exactly sounds like a published interface, heh? Especially as there's
not sane way to use it outside memory managment code.
next prev parent reply other threads:[~2004-09-27 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 17:03 [PATCH] __VMALLOC_RESERVE export Antony Suter
2004-09-27 17:12 ` Christoph Hellwig
2004-09-27 18:26 ` Antony Suter
2004-09-27 18:43 ` Christoph Hellwig
2004-09-27 19:55 ` Tonnerre
2004-09-27 20:15 ` Christoph Hellwig [this message]
2004-09-27 19:53 ` Tonnerre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927211504.A27577@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suterant@users.sourceforge.net \
--cc=tonnerre@thundrix.ch \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox