Re: [PATCH 2.6.8.1] drivers/char: New serial driver.

Russell King
2004-09-27T20:39:26Z

> IBM has requested this submission into the Linux kernel.
>
> The patch is quite large (300K uncompressed), so rather than attach it
> I am submitting a link to our ftp site where the patch is located.
>
> ftp://ftp1.digi.com/pub/patches/dgnc.patch

A few comments:

(1) I'm disappointed that you aren't using the serial_core support
in drivers/serial.
(2) I'm also concerned that you're using serial_reg.h as a description
of an interface between your hardware specific drivers and your
hardware independent tty core. It isn't a description of such an
interface and therefore should not be used as such. Please fix
your code in respect to this.
(3) loopback mode is normally enabled by setting TIOCM_LOOP modem
control bit via the TIOCMBIS ioctl.

I'd also like Alan Cox to look over the driver since he's looking at
the tty layer. Alan may have further comments since I've only briefly
looked through it.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core