From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
germano.barreiro@cyclades.com
Subject: Re: [PATCH] cyclades.c sysfs statistics support
Date: Tue, 28 Sep 2004 12:57:53 -0300 [thread overview]
Message-ID: <20040928155753.GC12494@logos.cnet> (raw)
In-Reply-To: <20040928141242.GA27728@kroah.com>
On Tue, Sep 28, 2004 at 07:12:43AM -0700, Greg KH wrote:
> On Tue, Sep 28, 2004 at 09:04:21AM -0300, Marcelo Tosatti wrote:
> > + device_create_file(&(cy_card[info->card].pdev->dev), &_cydas[line]);
>
> Why the array of attributes? As you only have one (which is wrong...)
> you only need one attribute structure.
Because each of them has a different name. I talked to him
and he will probably stick the attribute inside each
device structure.
> > + show_sys_data - shows the data exported to sysfs/device, mostly the signals status involved in the
> > + serial communication such as CTS,RTS,DTS,etc
>
> NO! sysfs is 1 value per file. Not a whole bunch of values per one
> file. Please change this to create a whole bunch of little files, not
> one big one.
Germano will do so.
We really appreciate your comments! Thanks.
prev parent reply other threads:[~2004-09-28 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-28 12:04 [PATCH] cyclades.c sysfs statistics support Marcelo Tosatti
2004-09-28 14:12 ` Greg KH
2004-09-28 15:57 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040928155753.GC12494@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=germano.barreiro@cyclades.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox