Re: [PATCH 0/8] Set of input (psmouse) patches

Vojtech Pavlik
2004-09-29T07:10:57Z

On Wed, Sep 29, 2004 at 01:40:53AM -0500, Dmitry Torokhov wrote:
> Hi Vojtech,
>
> Here is new bunch of small psmouse patches. Nothing particularly interesting
> except probably exporting rate, resolution, resetafter and smartscroll
> parameters as sysfs attributes. Protocol exporting and switching is still
> in progress though...
>
> 01-alps-signature.patch
> - add a new signature to ALPS response table (Inspiron 8500)
>
> 02-rate-resolution-handlers.patch
> - add set_rate and set_resolution handlers to psmouse structure
> to reduce dependencies between protocols, helps wihen exporting
> resolutin and rate via sysfs
>
> 03-synaptics-guest-protocol-switch.patch
> - not only set 4 byte guest protocol but also reset it back to 3
> if for some odd reason user reconnects guest requesting lower
> protocol.
>
> 04-psmouse-probe-fix.patch
> - patch from Marko Macek dealing with probing and his KVM (the thing
> doctors stream and gets confused by the extended probes)
>
> 05-psmouse-sysfs-attr.patch
> - export rate, resolution, resetafter and smartscroll as sysfs
> attributes.
>
> 06-psmouse-drop-ps2tpp.patch
> - get rid of PS2T++ protocol symbol as it it handled exactly the same
> as PS2++. This leaves space for THINKPS protocol and allows keeping
> old Synaptics and Alps protocol numbers that Synaptics X driver
> relied on.
>
> 07-separate-ps2pp-handling.patch
> - complete separation of PS2++ protocol deconding by moving everything
> into logips2pp.c - cleanup.
>
> 08-psmouse-packet-size.patch
> - add pktsize to psmouse structure and check it instead on relying on
> protcol numbering. Also rearrange detect routines in preparation to
> dynamic protocol switching via sysfs.
>
> Please let me know what you think and I will push it on bkbits.

All look OK, except for the last one. I'll comment in the patch itself.

--
Vojtech Pavlik
SuSE Labs, SuSE CR