From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, jgarzik@pobox.com
Subject: Re: PATCH: 3c59x 00:00:00:00:00:00 MAC failure
Date: Wed, 29 Sep 2004 17:45:31 +0100 [thread overview]
Message-ID: <20040929174530.D16537@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040929163023.GA17899@devserv.devel.redhat.com>; from alan@redhat.com on Wed, Sep 29, 2004 at 12:30:23PM -0400
On Wed, Sep 29, 2004 at 12:30:23PM -0400, Alan Cox wrote:
> The 3com EEPROM has a checksum but unfortunately it seems that a zapped
> EEPROM returning all zero values passes the checksum test fine and we try
> and use it.
>
>
> --- drivers/net/3c59x.c~ 2004-09-29 17:23:42.964453264 +0100
> +++ drivers/net/3c59x.c 2004-09-29 17:28:40.358242536 +0100
> @@ -1295,6 +1295,13 @@
> for (i = 0; i < 6; i++)
> printk("%c%2.2x", i ? ':' : ' ', dev->dev_addr[i]);
> }
> + /* Unfortunately an all zero eeprom passes the checksum and this
> + gets found in the wild in failure cases. Crypto is hard 8) */
> + if (memcmp(dev->dev_addr, "\0\0\0\0\0", 6) == 0) {
Shouldn't this be using is_valid_ether_addr() ?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-09-29 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 16:30 PATCH: 3c59x 00:00:00:00:00:00 MAC failure Alan Cox
2004-09-29 16:45 ` Russell King [this message]
2004-09-29 16:52 ` Jeff Garzik
2004-09-29 15:58 ` Alan Cox
2004-09-29 17:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040929174530.D16537@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox