From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@infradead.org>,
Hanna Linder <hannal@us.ibm.com>,
linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org,
kraxel@bytesex.org
Subject: Re: [PATCH 2.6.9-rc2-mm4 bttv-driver.c][4/8] convert pci_find_device to pci_dev_present
Date: Wed, 29 Sep 2004 14:11:35 -0700 [thread overview]
Message-ID: <20040929211135.GA24407@kroah.com> (raw)
In-Reply-To: <20040929220344.A17872@infradead.org>
On Wed, Sep 29, 2004 at 10:03:44PM +0100, Christoph Hellwig wrote:
> On Wed, Sep 29, 2004 at 01:55:22PM -0700, Hanna Linder wrote:
> >
> > As pci_find_device is going away need to replace it. This file did not use the dev returned
> > from pci_find_device so is replaceable by pci_dev_present. I was not able to test it
> > as I do not have the hardware.
>
> I think this check should just go away completely.
Good point. Especially as pci_module_init() can never return -ENODEV
anymore :)
Hanna, care to respin this patch?
thanks,
greg k-h
next prev parent reply other threads:[~2004-09-29 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 20:55 [PATCH 2.6.9-rc2-mm4 bttv-driver.c][4/8] convert pci_find_device to pci_dev_present Hanna Linder
2004-09-29 21:03 ` Christoph Hellwig
2004-09-29 21:11 ` Greg KH [this message]
2004-09-29 21:43 ` Hanna Linder
2004-09-29 22:28 ` [Kernel-janitors] " Matthew Wilcox
2004-09-29 22:32 ` Hanna Linder
2004-09-29 22:23 ` Tonnerre
2004-09-30 8:23 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040929211135.GA24407@kroah.com \
--to=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox