From: Andrew Morton <akpm@osdl.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: herbert@gondor.apana.org.au, benh@kernel.crashing.org,
linux-kernel@vger.kernel.org, mdz@canonical.com
Subject: Re: [PATCH] Use msleep_interruptible for therm_adt7467.c kernel thread
Date: Wed, 29 Sep 2004 21:40:33 -0700 [thread overview]
Message-ID: <20040929214033.4d800242.akpm@osdl.org> (raw)
In-Reply-To: <1096289501.9930.19.camel@localhost.localdomain>
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> On Llu, 2004-09-27 at 11:25, Herbert Xu wrote:
> > The continue is just paranoia in case something relies on the sleep
> > to take 2 seconds or more.
>
> If the signal occurs then you'll spin for 2 seconds because the signal
> is still waiting to be serviced. This therefore looks broken
It's a kernel thread, so unless it has taken explicit action to enable
signals, it should be OK.
prev parent reply other threads:[~2004-09-30 1:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 10:25 [PATCH] Use msleep_interruptible for therm_adt7467.c kernel thread Herbert Xu
2004-09-27 12:51 ` Alan Cox
2004-09-29 1:58 ` Herbert Xu
2004-09-29 1:24 ` Alan Cox
2004-09-29 4:12 ` Benjamin Herrenschmidt
2004-09-29 4:13 ` Benjamin Herrenschmidt
2004-09-30 4:40 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040929214033.4d800242.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mdz@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox