From: Gerd Knorr <kraxel@bytesex.org>
To: Tonnerre <tonnerre@thundrix.ch>
Cc: Christoph Hellwig <hch@infradead.org>,
Hanna Linder <hannal@us.ibm.com>,
linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org,
greg@kroah.com
Subject: Re: [PATCH 2.6.9-rc2-mm4 bttv-driver.c][4/8] convert pci_find_device to pci_dev_present
Date: Thu, 30 Sep 2004 10:23:05 +0200 [thread overview]
Message-ID: <20040930082305.GB20456@bytesex> (raw)
In-Reply-To: <20040929222353.GF21770@thundrix.ch>
On Thu, Sep 30, 2004 at 12:23:53AM +0200, Tonnerre wrote:
> Salut,
>
> On Wed, Sep 29, 2004 at 10:03:44PM +0100, Christoph Hellwig wrote:
> > I think this check should just go away completely.
> > We don't have such silly warnings in any other driver.
>
> Kraxel introduced this check because of the confusion with the "old"
> and "new" WinTV cards. The older one had a bt848 chip, the newer one a
> connexant 878, and only the older one was supported by Linux.
Yep, that was the reason. It's pretty much obsolete these days through
as we have a working (well, sort of, depending on the tv norm sound may
be a problem ...) driver for these cards in mainline. Just dropping
that now is perfectly fine.
Gerd
--
return -ENOSIG;
prev parent reply other threads:[~2004-09-30 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 20:55 [PATCH 2.6.9-rc2-mm4 bttv-driver.c][4/8] convert pci_find_device to pci_dev_present Hanna Linder
2004-09-29 21:03 ` Christoph Hellwig
2004-09-29 21:11 ` Greg KH
2004-09-29 21:43 ` Hanna Linder
2004-09-29 22:28 ` [Kernel-janitors] " Matthew Wilcox
2004-09-29 22:32 ` Hanna Linder
2004-09-29 22:23 ` Tonnerre
2004-09-30 8:23 ` Gerd Knorr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930082305.GB20456@bytesex \
--to=kraxel@bytesex.org \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tonnerre@thundrix.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox