From: Ashok Raj <ashok.raj@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
greg@kroah.com, ashok.raj@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add hook for PCI resource deallocation
Date: Thu, 30 Sep 2004 15:21:17 -0700 [thread overview]
Message-ID: <20040930152117.A30196@unix-os.sc.intel.com> (raw)
In-Reply-To: <20040930145014.71e04b25.akpm@osdl.org>; from akpm@osdl.org on Thu, Sep 30, 2004 at 02:50:14PM -0700
On Thu, Sep 30, 2004 at 02:50:14PM -0700, Andrew Morton wrote:
> Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> wrote:
> >
> > I'm attaching updated patches for adding pcibiod_disable_device()
> > hook based on the feedback from Ashok (Thank you, Ashok!).
>
> This appears to be a patch-reversed version of the patch which is already
> in -mm:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.9-rc2/2.6.9-rc2-mm4/broken-out/add-hook-for-pci-resource-deallocation.patch
>
> So I'm not sure what you're trying to do here.
In the original patch, Kenji added a dummy function in several source files. Instead now
the new patch should have a single default implementation with a __attribute__((weak))
As a result its removing all the old additions and now keeping just a single default function.
so yes, its a reverse patch mostly, but there should also be a new function added with the weak
attribute.
--
Cheers,
Ashok Raj
- Linux OS & Technology Team
next prev parent reply other threads:[~2004-09-30 22:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 12:54 [PATCH] add hook for PCI resource deallocation Kenji Kaneshige
2004-09-17 21:49 ` Greg KH
2004-09-21 1:35 ` Kenji Kaneshige
2004-09-24 0:49 ` Kenji Kaneshige
2004-09-24 20:02 ` Ashok Raj
2004-09-24 21:22 ` Greg KH
2004-09-27 8:06 ` Kenji Kaneshige
2004-09-28 22:00 ` Greg KH
2004-09-29 0:55 ` Kenji Kaneshige
2004-09-30 21:50 ` Andrew Morton
2004-09-30 22:21 ` Ashok Raj [this message]
2004-09-30 23:03 ` Andrew Morton
2004-10-01 2:11 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930152117.A30196@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox