From: maximilian attems <janitor@sternwelten.at>
To: linux-kernel@vger.kernel.org
Cc: marcelo.tosatti@cyclades.com, sam@ravnborg.org, arnold@skeeve.com
Subject: Re: [patch 2.4] menuconfig fix crash due to infinite recursion
Date: Thu, 30 Sep 2004 21:33:45 +0200 [thread overview]
Message-ID: <20040930193345.GA1848@stro.at> (raw)
In-Reply-To: <20040929161905.GK1835@stro.at>
gawk(1) tells that getline "returns 0 on end of file and -1 on an error."
in current script for menuconfig if getline has an error,
it is still treated as true, fix _both_ of its invocations.
2.6 don't use that script anymore.
fix suggestion from Aharon Robbins <arnold@skeeve.com>
debian bts has 2 bugs open concerning that issue,
this is the one containing belows fix:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=147469
[TM] tested.
menuconfig still works for me. ;)
--- a/scripts/Menuconfig 2002-08-03 02:39:46.000000000 +0200
+++ b/scripts/Menuconfig 2004-09-30 21:29:21.000000000 +0200
@@ -714,7 +714,7 @@ BEGIN {
function parser(ifile,menu) {
- while (getline <ifile) {
+ while ((getline <ifile) > 0) {
if ($1 == "mainmenu_option") {
comment_is_option = "1"
}
@@ -761,7 +761,7 @@ BEGIN {
function parser(ifile,menu) {
- while (getline <ifile) {
+ while ((getline <ifile) > 0) {
if ($0 ~ /^#|$MAKE|mainmenu_name/) {
printf("") >>menu
}
--
maks
kernel janitor http://janitor.kernelnewbies.org/
prev parent reply other threads:[~2004-09-30 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 16:19 [patch 2.4] menuconfig fix crash due to infinite recursion maks attems
2004-09-30 19:33 ` maximilian attems [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930193345.GA1848@stro.at \
--to=janitor@sternwelten.at \
--cc=arnold@skeeve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox