Re: PATCH: (Test) it8212 driver for 2.6.9rc3

Bartlomiej Zolnierkiewicz
2004-09-30T22:04:22Z

On Thursday 30 September 2004 23:35, Alan Cox wrote:
> On Thu, Sep 30, 2004 at 10:45:18PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > - merge+describe needed IDE core changes
>
> Happily. I'm of the opinion the "ident whacking" callback isnt justified,
> only one driver has a need for it and that driver can do it in the iops hook.

ok, you are right

> > - fix coding style and whitespace damage
>
> Yeah
>
> > - kill useless DECLARE_ITE_DEV macro
>
> I'd prefer to keep it (there are likely to be some related devices from
> the databook)

you can add it when needed

> > - add __init to it8212_ide_init()
>
> Good point - will fix

thanks