public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "J.A. Magallon" <jamagallon@able.es>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: Stack traces in 2.6.9-rc2-mm4
Date: Fri, 1 Oct 2004 00:56:40 +0200	[thread overview]
Message-ID: <20040930225640.GA6441@elte.hu> (raw)
In-Reply-To: <1096581484l.9853l.0l@werewolf.able.es>


* J.A. Magallon <jamagallon@able.es> wrote:

> Sep 30 23:54:41 werewolf pumpd[9843]: intf: broadcast: 255.255.255.255
> Sep 30 23:54:41 werewolf pumpd[9843]: intf: network: 82.198.40.0
> Sep 30 23:54:41 werewolf kernel: using smp_processor_id() in preemptible 
> code: pump/9843
> Sep 30 23:54:41 werewolf kernel:  [smp_processor_id+135/141] 
> smp_processor_id+0x87/0x8d
> Sep 30 23:54:41 werewolf kernel:  [<b011bc8f>] smp_processor_id+0x87/0x8d
> Sep 30 23:54:41 werewolf kernel:  [pg0+1079594592/1337930752] 
> death_by_timeout+0x11/0x65 [ip_conntrack]
> Sep 30 23:54:41 werewolf kernel:  [<f099fe60>] death_by_timeout+0x11/0x65 
> [ip_conntrack]

does the patch below fix these for you?

	Ingo

--- include/linux/netfilter_ipv4/ip_conntrack.h.orig
+++ include/linux/netfilter_ipv4/ip_conntrack.h
@@ -311,7 +311,7 @@ struct ip_conntrack_stat
 	unsigned int expect_delete;
 };
 
-#define CONNTRACK_STAT_INC(count) (__get_cpu_var(ip_conntrack_stat).count++)
+#define CONNTRACK_STAT_INC(count) (per_cpu(ip_conntrack_stat, _smp_processor_id()).count++)
 
 /* eg. PROVIDES_CONNTRACK(ftp); */
 #define PROVIDES_CONNTRACK(name)                        \

  reply	other threads:[~2004-09-30 22:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-27  8:01 Stack traces in 2.6.9-rc2-mm4 Reuben Farrelly
2004-09-27  8:23 ` Nick Piggin
2004-09-27  8:57 ` Ingo Molnar
2004-09-27  9:14   ` Reuben Farrelly
2004-09-27 23:12   ` J.A. Magallon
2004-09-28  7:21     ` Ingo Molnar
2004-09-28  7:49       ` Nick Piggin
2004-09-28 10:24         ` Ingo Molnar
2004-09-28 10:48           ` Nick Piggin
2004-09-30 21:58       ` J.A. Magallon
2004-09-30 22:56         ` Ingo Molnar [this message]
2004-09-30 23:16           ` J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040930225640.GA6441@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox