public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <adrian.bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: [patch] 2.6.9-rc3-mm1: X86_LOCAL_APIC compile error
Date: Sat, 2 Oct 2004 11:56:09 +0200	[thread overview]
Message-ID: <20041002095609.GA2470@stusta.mhn.de> (raw)
In-Reply-To: <20041002014352.2b55e98d.akpm@osdl.org>

On Sat, Oct 02, 2004 at 01:43:52AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.9-rc2-mm4:
>...
> +generic-irq-subsystem-x86-port.patch
>...
>  IRQ handling code consolidation
>...


This causes the following compile error with X86_LOCAL_APIC=y:

<--  snip  -->

...
  CC      init/main.o
In file included from include/linux/hardirq.h:6,
                 from include/linux/interrupt.h:11,
                 from include/asm/highmem.h:24,
                 from include/linux/highmem.h:14,
                 from include/linux/skbuff.h:27,
                 from include/linux/security.h:33,
                 from init/main.c:36:
include/asm/hardirq.h: In function `ack_bad_irq':
include/asm/hardirq.h:34: warning: implicit declaration of function 
`ack_APIC_irq'
In file included from include/asm/smp.h:22,
                 from init/main.c:65:
include/asm/apic.h: At top level:
include/asm/apic.h:72: error: conflicting types for 'ack_APIC_irq'
include/asm/hardirq.h:34: error: previous implicit declaration of 
'ack_APIC_irq' was here
make[1]: *** [init/main.o] Error 1

<--  snip  -->


The following patch fixes this issue:


Signed-off-by: Adrian Bunk <bunk@fs.tum.de>

--- linux-2.6.9-rc3-mm1-full/include/asm-i386/hardirq.h.old	2004-10-02 11:46:13.000000000 +0200
+++ linux-2.6.9-rc3-mm1-full/include/asm-i386/hardirq.h	2004-10-02 11:46:38.000000000 +0200
@@ -4,6 +4,7 @@
 #include <linux/config.h>
 #include <linux/threads.h>
 #include <linux/irq.h>
+#include <asm/apic.h>
 
 typedef struct {
 	unsigned int __softirq_pending;


  parent reply	other threads:[~2004-10-02  9:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-02  8:43 2.6.9-rc3-mm1 Andrew Morton
2004-10-02  9:47 ` 2.6.9-rc3-mm1 Tim Cambrant
2004-10-02  9:56 ` Adrian Bunk [this message]
2004-10-02 10:00   ` [patch] 2.6.9-rc3-mm1: X86_LOCAL_APIC compile error Ingo Molnar
2004-10-02 14:27 ` 2.6.9-rc3-mm1 Alexander Nyberg
2004-10-02 16:26 ` 2.6.9-rc3-mm1 white phoenix
2004-10-02 19:29 ` 2.6.9-rc3-mm1 [immediate crash on AMD64] Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041002095609.GA2470@stusta.mhn.de \
    --to=adrian.bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox