public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* missing tty in sclp_tty.c and sclp_vt220.c
@ 2004-10-02 12:52 Olaf Hering
  2004-10-02 14:56 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2004-10-02 12:52 UTC (permalink / raw)
  To: Alan Cox, Martin Schwidefsky; +Cc: linux-kernel

Alan,

what 'tty' did you mean here? gcc says its undeclared.

should that be sclp_tty and sclp_vt220_tty?

diff -Nru a/drivers/s390/char/sclp_tty.c b/drivers/s390/char/sclp_tty.c
--- a/drivers/s390/char/sclp_tty.c      2004-09-29 20:07:09 -07:00
+++ b/drivers/s390/char/sclp_tty.c      2004-09-29 20:07:09 -07:00
@@ -277,10 +277,7 @@
        wake_up(&sclp_tty_waitq);
        /* check if the tty needs a wake up call */
        if (sclp_tty != NULL) {
-               if ((sclp_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
-                   sclp_tty->ldisc.write_wakeup)
-                       (sclp_tty->ldisc.write_wakeup)(sclp_tty);
-               wake_up_interruptible(&sclp_tty->write_wait);
+               tty_wakeup(tty);
        }
 }

diff -Nru a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
--- a/drivers/s390/char/sclp_vt220.c    2004-09-29 20:06:20 -07:00
+++ b/drivers/s390/char/sclp_vt220.c    2004-09-29 20:06:20 -07:00
@@ -139,10 +139,7 @@
        wake_up(&sclp_vt220_waitq);
        /* Check if the tty needs a wake up call */
        if (sclp_vt220_tty != NULL) {
-               if ((sclp_vt220_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
-                   (sclp_vt220_tty->ldisc.write_wakeup != NULL))
-                       (sclp_vt220_tty->ldisc.write_wakeup)(sclp_vt220_tty);
-               wake_up_interruptible(&sclp_vt220_tty->write_wait);
+               tty_wakeup(tty);
        }
 }



-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: missing tty in sclp_tty.c and sclp_vt220.c
  2004-10-02 12:52 missing tty in sclp_tty.c and sclp_vt220.c Olaf Hering
@ 2004-10-02 14:56 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2004-10-02 14:56 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Alan Cox, Martin Schwidefsky, linux-kernel

On Sat, Oct 02, 2004 at 02:52:20PM +0200, Olaf Hering wrote:
> Alan,
> should that be sclp_tty and sclp_vt220_tty?

Yes. The patch is correct.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-10-02 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-02 12:52 missing tty in sclp_tty.c and sclp_vt220.c Olaf Hering
2004-10-02 14:56 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox