public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Too many __s in donauboe.h
@ 2004-10-04 12:01 Pavel Machek
  2004-10-04 13:43 ` Paul Jackson
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Machek @ 2004-10-04 12:01 UTC (permalink / raw)
  To: kernel list, Rusty trivial patch monkey Russell, Andrew Morton

Hi!

donauboe.h is kernel code, therefore it does not need __s. Please
apply,

								Pavel

Index: linux/drivers/net/irda/donauboe.h
===================================================================
--- linux.orig/drivers/net/irda/donauboe.h	2004-10-01 12:24:25.000000000 +0200
+++ linux/drivers/net/irda/donauboe.h	2004-08-19 12:21:14.000000000 +0200
@@ -268,12 +268,11 @@
 
 struct OboeSlot
 {
-  __u16 len;                    /*Tweleve bits of packet length */
-  __u8 unused;
-  __u8 control;                 /*Slot control/status see below */
-  __u32 address;                /*Slot buffer address */
-}
-__attribute__ ((packed));
+  u16 len;                    /*Tweleve bits of packet length */
+  u8 unused;
+  u8 control;                 /*Slot control/status see below */
+  u32 address;                /*Slot buffer address */
+} __attribute__ ((packed));
 
 #define OBOE_NTASKS OBOE_TXRING_OFFSET_IN_SLOTS
 
@@ -316,7 +315,7 @@
   chipio_t io;                  /* IrDA controller information */
   struct qos_info qos;          /* QoS capabilities for this device */
 
-  __u32 flags;                  /* Interface flags */
+  u32 flags;                  /* Interface flags */
 
   struct pci_dev *pdev;         /*PCI device */
   int base;                     /*IO base */


-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Too many __s in donauboe.h
  2004-10-04 12:01 Too many __s in donauboe.h Pavel Machek
@ 2004-10-04 13:43 ` Paul Jackson
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Jackson @ 2004-10-04 13:43 UTC (permalink / raw)
  To: Pavel Machek; +Cc: linux-kernel, trivial, akpm

Pavel wrote:
> @@ -316,7 +315,7 @@
>    chipio_t io;                  /* IrDA controller information */
>    struct qos_info qos;          /* QoS capabilities for this device */
>  
> -  __u32 flags;                  /* Interface flags */
> +  u32 flags;                  /* Interface flags */
>  
>    struct pci_dev *pdev;         /*PCI device */
>    int base;                     /*IO base */

Trading a couple of ugly underscores, for an ugly off by two spacing?
Sounds like progress to me ;).

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-10-04 13:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-04 12:01 Too many __s in donauboe.h Pavel Machek
2004-10-04 13:43 ` Paul Jackson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox