Re: 2.6.9-rc3-mm2

Ingo Molnar
2004-10-04T21:50:33Z

* Andrew Morton <akpm@osdl.org> wrote:

> Ingo Molnar <mingo@elte.hu> wrote:
> >
> > Must not put side-effects into a macro that is NOP on
> > !SMP.
>
> This one, too:
>
> - per_cpu(ip_conntrack_stat, get_cpu()).count++; \
> - put_cpu(); \

btw., also remove or fix the get_cpu_ptr() definition in percpu.h, it's
buggy for the same reason, but fortunately unused.

Ingo