From: Andrew Morton <akpm@osdl.org>
To: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
Cc: jeffpc@optonline.net, linux-kernel@vger.kernel.org,
torvalds@osdl.org, trivial@rustcorp.com.au,
rusty@rustcorp.com.au
Subject: Re: [PATCH 2.6][resend] Add DEVPATH env variable to hotplug helper call
Date: Mon, 4 Oct 2004 12:37:25 -0700 [thread overview]
Message-ID: <20041004123725.58f1e77c.akpm@osdl.org> (raw)
In-Reply-To: <20041004102220.A3304@unix-os.sc.intel.com>
Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com> wrote:
>
> On Sun, Oct 03, 2004 at 04:20:12PM -0700, Andrew Morton wrote:
> > Does CPU hotplug behave correctly wrt /sys/devices/system/cpu? Given that
> > register_cpu() is still marked __init, I assume not.
>
> Currently what we have in the kernel is logical cpu hotplug, i.e once the
> cpu is registered via register_cpu() that cpu can only go offline and still
> the entry for that cpu will be present in the /sys/devices/system/cpu/cpuX/online.
>
> So __init register_cpu() is fine untill we support unregister_cpu()
> which is required for physical cpu hotplug case.
>
> I have submitted ACPI based physical cpu hotplug patches and waiting to here from
> ACPI mainitainer Len Brown, there I have taken care to support unregister_cpu()
> and register_cpu() is marked as __devinit in those patches.
OK...
But still, cpu_run_sbin_hotplug() should not exist. It is duplicating
(indeed, emulating) kobject_hotplug() behaviour. To the extent that it now
has a hardwired sysfs path embedded in it:
sprintf(devpath_str, "DEVPATH=devices/system/cpu/cpu%d", cpu);
which should have been obtained from kobject_get_path().
next prev parent reply other threads:[~2004-10-04 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-03 10:08 [PATCH 2.6][resend] Add DEVPATH env variable to hotplug helper call Josef 'Jeff' Sipek
2004-10-03 23:20 ` Andrew Morton
2004-10-04 17:22 ` Keshavamurthy Anil S
2004-10-04 19:37 ` Andrew Morton [this message]
2004-10-04 19:43 ` Keshavamurthy Anil S
2004-10-05 8:25 ` Keshavamurthy Anil S
2004-10-05 17:18 ` Andrew Morton
2004-10-05 17:27 ` Keshavamurthy Anil S
2004-10-05 17:47 ` Andrew Morton
2004-10-05 18:01 ` Keshavamurthy Anil S
2004-10-05 18:23 ` Andrew Morton
2004-10-05 19:02 ` Keshavamurthy Anil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004123725.58f1e77c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=jeffpc@optonline.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox