From: Jens Axboe <axboe@suse.de>
To: Borislav Petkov <petkov@uni-muenster.de>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>,
Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Fw: Re: 2.6.9-rc2-mm4
Date: Mon, 4 Oct 2004 19:36:21 +0200 [thread overview]
Message-ID: <20041004173620.GA5707@suse.de> (raw)
In-Reply-To: <200410041754.25677.petkov@uni-muenster.de>
On Mon, Oct 04 2004, Borislav Petkov wrote:
> Ok here we go,
>
> final results:
>
> 2.6.8-rc1: OK
> 2.6.8-rc2: OK
> 2.6.8-rc3: OK
> 2.6.8-rc3-bk1: OK
> 2.6.8-rc3-bk2: OK
> 2.6.8-rc3-bk3: OK
> 2.6.8-rc3-bk4: OK
> 2.6.8-rc4: BUG!
>
> So, assuming that everything went fine during testing, the bug got introduced
> in the transition between 2.6.8-rc3-bk4 and 2.6.8-rc4.
That's some nice testing, thank you. Try backing out this hunk:
diff -urp linux-2.6.8-rc3-bk4/drivers/block/scsi_ioctl.c linux-2.6.8-rc4/drivers/block/scsi_ioctl.c
--- linux-2.6.8-rc3-bk4/drivers/block/scsi_ioctl.c 2004-08-03 23:28:51.000000000 +0200
+++ linux-2.6.8-rc4/drivers/block/scsi_ioctl.c 2004-08-10 04:24:08.000000000 +0200
@@ -90,7 +90,7 @@ static int sg_set_reserved_size(request_
if (size < 0)
return -EINVAL;
if (size > (q->max_sectors << 9))
- return -EINVAL;
+ size = q->max_sectors << 9;
q->sg_reserved_size = size;
return 0;
It's the only thing that sticks out, and it could easily explain it if
your cd ripper starts issuing requests that are too big. Maybe even add
a printk() here, so it will look like this in the kernel you test:
if (size > (q->sectors << 9)) {
printk("%u rejected\n", size);
return -EINVAL;
}
to verify.
--
Jens Axboe
next prev parent reply other threads:[~2004-10-04 17:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040929214637.44e5882f.akpm@osdl.org>
[not found] ` <200409301452.52134.bzolnier@elka.pw.edu.pl>
2004-09-30 15:32 ` Fw: Re: 2.6.9-rc2-mm4 Borislav Petkov
2004-09-30 16:25 ` Bartlomiej Zolnierkiewicz
2004-09-30 21:46 ` Borislav Petkov
2004-09-30 23:30 ` Bartlomiej Zolnierkiewicz
2004-10-01 5:43 ` Borislav Petkov
2004-10-01 9:18 ` Jens Axboe
2004-10-01 9:54 ` Borislav Petkov
2004-10-01 9:54 ` Jens Axboe
2004-10-01 10:34 ` Borislav Petkov
2004-10-01 10:47 ` Jens Axboe
2004-10-01 11:03 ` Borislav Petkov
2004-10-01 18:42 ` Borislav Petkov
2004-10-03 7:51 ` Borislav Petkov
2004-10-04 15:54 ` Borislav Petkov
2004-10-04 17:36 ` Jens Axboe [this message]
2004-10-04 20:12 ` Borislav Petkov
2004-10-04 20:42 ` Jens Axboe
2004-10-04 21:11 ` Borislav Petkov
2004-10-05 7:12 ` Jens Axboe
2004-10-05 9:29 ` Borislav Petkov
2004-10-04 21:14 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004173620.GA5707@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=petkov@uni-muenster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox