From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alex Williamson <alex.williamson@hp.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] set membase in serial8250_request_port
Date: Mon, 4 Oct 2004 22:04:19 +0100 [thread overview]
Message-ID: <20041004220419.C21216@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1096916062.4510.20.camel@tdi>; from alex.williamson@hp.com on Mon, Oct 04, 2004 at 12:54:22PM -0600
On Mon, Oct 04, 2004 at 12:54:22PM -0600, Alex Williamson wrote:
>
> I'm running into a problem that seems to be caused by this really old
> changeset:
>
> http://linux.bkbits.net:8080/linux-2.5/cset@3d9f67f2BWvXiLsZCFwD-8s_E9AN6A
>
> When I run 'setserial /dev/ttyS1 uart 16450' on an ia64 system w/ MMIO
> UARTs, I get a NAT consumption oops from the kernel. The problem is
> that this code path calls serial8250_release_port() where the membase
> gets cleared. However, the subsequent call to serial8250_request_port()
> doesn't restore membase, causing a read from a bad address. I don't see
> many users of the UPF_IOREMAP flag, so I think the solution is to simply
> make the remap case symmetric to the unmap case. Patch below. Thanks,
Mostly correct reasoning, but the solution is wrong. Consider what
happens if we call request_port where we have set mapbase and pre-
initialised membase for a memory mapped port (eg, PCI card.)
This would cause us to re-ioremap the mapbase, which is wrong. We
must obey the UPF_IOREMAP flag here. Note also that this fix you're
reverting will break 8250 for PPC people...
Could you give further information about the problem you're seeing?
Bear in mind that I know precisely zero about ia64 oopsen so you'll
probably have to explain it to me in detail.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-10-04 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 18:54 [PATCH] set membase in serial8250_request_port Alex Williamson
2004-10-04 21:04 ` Russell King [this message]
2004-10-04 21:43 ` Alex Williamson
2004-10-18 14:56 ` Alex Williamson
2004-10-28 19:24 ` Alex Williamson
2004-10-30 10:28 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004220419.C21216@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=alex.williamson@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox