Re: 2.6.9-rc3-mm3

[Greg KH <greg@kroah.com>]

On Thu, Oct 07, 2004 at 11:06:53PM +0000, J.A. Magallon wrote:
> 
> On 2004.10.08, Andrew Morton wrote:
> >"J.A. Magallon" <jamagallon@able.es> wrote:
> >>
> >> Thanks, that made it work again !!
> >> 
> >> Total set of patches to boot:
> >> - your latest fix
> >> - revert optimize profile + Andi's patch
> >> - uhci fix (still needed ?)
> >
> >I don't know anything about the uhci fix.  Sending a changelogged,
> >signed-off patch would hep get the ball rolling.
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=109690445623905&w=2
> 
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> 
> ===== drivers/usb/host/uhci-hcd.c 1.134 vs edited =====
> --- 1.134/drivers/usb/host/uhci-hcd.c	2004-09-30 13:58:40 -04:00
> +++ edited/drivers/usb/host/uhci-hcd.c	2004-10-04 10:37:21 -04:00
> @@ -2412,7 +2412,7 @@
> 		goto up_failed;
> 
> 	retval = pci_register_driver(&uhci_pci_driver);
> -	if (retval)
> +	if (retval < 0)
> 		goto init_failed;
> 
> 	return 0;

This should not be needed anymore, as I've fixed up the
pci_register_driver() call to be sane.  If you are having problems,
please let me know about it.

thanks,

greg k-h