From: Andi Kleen <ak@muc.de>
To: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make gcc -align options .config-settable
Date: 8 Oct 2004 17:42:27 +0200
Date: Fri, 8 Oct 2004 17:42:27 +0200 [thread overview]
Message-ID: <20041008154227.GA91816@muc.de> (raw)
In-Reply-To: <200410081710.58766.vda@port.imtp.ilyichevsk.odessa.ua>
On Fri, Oct 08, 2004 at 05:10:58PM +0000, Denis Vlasenko wrote:
> On Friday 08 October 2004 12:20, Andi Kleen wrote:
> > Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> writes:
> > > Resend.
> > >
> > > With all alignment options set to 1 (minimum alignment),
> > > I've got 5% smaller vmlinux compared to one built with
> > > default code alignment.
> > >
> > > Rediffed against 2.6.9-rc3.
> > > Please apply.
> >
> > I agree with the basic idea (the big alignments also always annoy
> > me when I look at disassembly), but I think your CONFIG options
> > are far too complicated. I don't think anybody will go as far as
> > to tune loops vs function calls.
> >
> > I would just do a single CONFIG_NO_ALIGNMENTS that sets everything to
> > 1, that should be enough.
>
> For me, yes, but there are people which are slightly less obsessed
> with code size than me.
>
> They might want to say "try to align to 16 bytes if
> it costs less than 5 bytes" etc.
If they want to go down to that low level they can as well edit
the Makefiles. But we already have far too many configs and
adding new ones for obscure compiler options is not a good idea.
Also we don't normally add stuff "just in case", but only when
people actually use it.
-Andi
next prev parent reply other threads:[~2004-10-08 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2KBq9-2S1-15@gated-at.bofh.it>
2004-10-08 12:20 ` [PATCH] Make gcc -align options .config-settable Andi Kleen
2004-10-08 17:10 ` Denis Vlasenko
2004-10-08 14:30 ` Grzegorz Kulewski
2004-10-08 20:42 ` Denis Vlasenko
2004-10-08 21:30 ` Grzegorz Kulewski
2004-10-08 15:42 ` Andi Kleen [this message]
2004-10-08 20:46 ` Denis Vlasenko
2004-10-01 19:26 Denis Vlasenko
2004-10-01 22:17 ` Andrew Morton
2004-10-04 22:04 ` Sam Ravnborg
2004-10-08 5:03 ` Keith Owens
2004-10-17 0:38 ` Sam Ravnborg
2004-10-04 18:38 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041008154227.GA91816@muc.de \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox