From: Greg KH <greg@kroah.com>
To: "Richard B. Johnson" <root@chaos.analogic.com>
Cc: Stephen Hemminger <shemminger@osdl.org>,
linus@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] protect against buggy drivers
Date: Fri, 8 Oct 2004 11:35:49 -0700 [thread overview]
Message-ID: <20041008183549.GB4842@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0410081430490.7079@chaos.analogic.com>
On Fri, Oct 08, 2004 at 02:31:27PM -0400, Richard B. Johnson wrote:
>
> In the meantime, can we do something like:
>
> --- linux-2.6.8/fs/char_dev.c.orig 2004-10-08 14:24:03.838389344 -0400
> +++ linux-2.6.8/fs/char_dev.c 2004-10-08 14:26:51.059967800 -0400
> @@ -206,7 +206,7 @@
>
> cdev->owner = fops->owner;
> cdev->ops = fops;
> - strcpy(cdev->kobj.name, name);
> + strncpy(cdev->kobj.name, name, KOBJ_NAME_LEN-1);
> for (s = strchr(cdev->kobj.name, '/'); s; s = strchr(s, '/'))
> *s = '!';
No, that's still wrong. Use Stephen's other patch instead.
thanks,
greg k-h
next prev parent reply other threads:[~2004-10-08 18:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-08 16:53 [PATCH] protect against buggy drivers Stephen Hemminger
2004-10-08 16:21 ` Alan Cox
2004-10-08 17:14 ` Greg KH
2004-10-08 17:29 ` Richard B. Johnson
2004-10-08 17:50 ` Greg KH
2004-10-08 18:31 ` Richard B. Johnson
2004-10-08 18:35 ` Greg KH [this message]
2004-10-08 19:32 ` Richard B. Johnson
2004-10-08 18:27 ` Stephen Hemminger
2004-10-08 18:36 ` Greg KH
2004-10-22 20:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041008183549.GB4842@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linus@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=root@chaos.analogic.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox