From: Arnd Bergmann <arnd@arndb.de>
To: "Jin, Gordon" <gordon.jin@intel.com>
Cc: <discuss@x86-64.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH x86_64]: Add TCSBRKP ioctl translation for arch/x86_64/ia32
Date: Sat, 9 Oct 2004 14:31:45 +0200 [thread overview]
Message-ID: <200410091431.48915.arnd@arndb.de> (raw)
In-Reply-To: <8126E4F969BA254AB43EA03C59F44E848AF8D0@pdsmsx404>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
On Sünnavend 09 Oktober 2004 11:47, Jin, Gordon wrote:
> --- linux-2.6.8/arch/x86_64/ia32/ia32_ioctl.c.orig 2004-09-23 09:21:20.000000000 -0700
> +++ linux-2.6.8/arch/x86_64/ia32/ia32_ioctl.c 2004-09-23 09:22:31.000000000 -0700
> @@ -189,6 +189,7 @@ COMPATIBLE_IOCTL(RTC_SET_TIME)
> COMPATIBLE_IOCTL(RTC_WKALM_SET)
> COMPATIBLE_IOCTL(RTC_WKALM_RD)
> COMPATIBLE_IOCTL(FIOQSIZE)
> +COMPATIBLE_IOCTL(TCSBRKP)
>
> /* And these ioctls need translation */
> HANDLE_IOCTL(TIOCGDEV, tiocgdev)
This is not the optimal solution, for two reasons:
- If it is needed on all architectures, you should instead remove it
from the ones that currently define it and put it in
include/linux/compat_ioctl.h.
- It is not actually COMPATIBLE_IOCTL, but rather ULONG_IOCTL,
as far as I can tell. Yes, I made the same mistake in
arch/s390/kernel/compat_ioctl.c, but you can fix it now
that you are touching it anyway.
Arnd <><
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2004-10-09 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-09 9:47 [PATCH x86_64]: Add TCSBRKP ioctl translation for arch/x86_64/ia32 Jin, Gordon
2004-10-09 12:31 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410091431.48915.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=discuss@x86-64.org \
--cc=gordon.jin@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox