public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: torvalds@osdl.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] find_isa_irq_pin can't be __init
Date: Sun, 10 Oct 2004 23:57:17 +0100	[thread overview]
Message-ID: <20041010225717.GA27705@redhat.com> (raw)

As spotted by one of our Fedora users, we sometimes
oops during shutdown (http://www.roberthancock.com/kerneloops.png)
because disable_IO_APIC() wants to call find_isa_irq_pin(),
which we threw away during init.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.8/arch/i386/kernel/io_apic.c~	2004-10-10 18:54:27.490567168 -0400
+++ linux-2.6.8/arch/i386/kernel/io_apic.c	2004-10-10 18:54:44.660956872 -0400
@@ -745,7 +745,7 @@ static int __init find_irq_entry(int api
 /*
  * Find the pin to which IRQ[irq] (ISA) is connected
  */
-static int __init find_isa_irq_pin(int irq, int type)
+static int find_isa_irq_pin(int irq, int type)
 {
 	int i;
 

             reply	other threads:[~2004-10-10 22:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-10 22:57 Dave Jones [this message]
2004-10-11 11:33 ` __init dependencies (was: Re: [PATCH] find_isa_irq_pin can't be )__init Geert Uytterhoeven
2004-10-11 19:12   ` Andrew Morton
2004-10-11 19:16     ` Dave Jones
2004-10-11 19:17     ` __init dependencies Randy.Dunlap
2004-10-12  4:04       ` Randy.Dunlap
2004-10-12  4:19         ` Andrew Morton
2004-10-12  6:06         ` Keith Owens
2004-10-20 16:08           ` [PATCH] __init dependencies: ignore __param Randy.Dunlap
     [not found] <fa.fq3ot7q.1fgua9u@ifi.uio.no>
2004-10-11  6:39 ` [PATCH] find_isa_irq_pin can't be __init Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041010225717.GA27705@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox