From: David Gibson <david@gibson.dropbear.id.au>
To: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc64-dev@lists.linuxppc.org,
Anton Blanchard <anton@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PPC64] xmon sparse cleanups
Date: Mon, 11 Oct 2004 12:11:46 +1000 [thread overview]
Message-ID: <20041011021146.GA1556@zax> (raw)
In-Reply-To: <16738.31164.464250.638432@cargo.ozlabs.ibm.com>
On Tue, Oct 05, 2004 at 08:38:52PM +1000, Paul Mackerras wrote:
> David Gibson writes:
>
> > Andrew, please apply:
> >
> > This patch removes many sparse warnings from the xmon code. Mostly
> > K&R function declarations and 0-instead-of-NULLs.
>
> The trouble with this patch is that it makes ppc-opc.c diverge from
> the version in binutils, which is where it came from. I'd rather keep
> it as close as possible to that version. I have no problem with the
> changes to the other files.
A corresponding patch has now gone into binutils CVS. As it happens
there has already been a certain amount of divergence between the
versions, presumably because the kernel copy hasn't been updated from
binutils in quite a while.
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next prev parent reply other threads:[~2004-10-11 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 6:42 [PPC64] xmon sparse cleanups David Gibson
2004-10-05 10:38 ` Paul Mackerras
2004-10-11 2:11 ` David Gibson [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-21 3:36 David Gibson
2004-10-23 8:20 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041011021146.GA1556@zax \
--to=david@gibson.dropbear.id.au \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox