From: Ingo Molnar <mingo@elte.hu>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: Zwane Mwaikambo <zwane@linuxpower.ca>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] i386 CPU hotplug updated for -mm
Date: Tue, 12 Oct 2004 08:04:10 +0200 [thread overview]
Message-ID: <20041012060410.GE1479@elte.hu> (raw)
In-Reply-To: <1097560787.6557.99.camel@biclops>
* Nathan Lynch <nathanl@austin.ibm.com> wrote:
> I fixed up the warning in cpu_down with the following patch and now am
> running with that + 2.6.9-rc4-mm1 + your patch while doing continuous
> online/offline and make -j8. It's been running for about 45 minutes
> and I haven't seen the panic yet, although I'm at a loss to explain
> why the change would fix it. Will let it run overnight and report
> back...
> /* Move it here so it can run. */
> - kthread_bind(p, smp_processor_id());
> + kthread_bind(p, get_cpu());
> + put_cpu();
> /* CPU is completely dead: tell everyone. Too late to complain. */
> if (notifier_call_chain(&cpu_chain, CPU_DEAD, (void *)(long)cpu)
hm, is there any assurance that smp_processor_id() == cpu?
but i agree, this fix shouldnt impact the bio-destruct slab crash you
were seeing.
Ingo
next prev parent reply other threads:[~2004-10-12 6:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-01 20:45 [patch 0/5, 2.6.9-rc3] generic irq subsystem, description Ingo Molnar
2004-10-01 20:46 ` [patch 1/5, 2.6.9-rc3] generic irq subsystem, core Ingo Molnar
2004-10-01 20:47 ` [patch 2/5, 2.6.9-rc3] generic irq subsystem, x86 port Ingo Molnar
2004-10-01 20:48 ` [patch 3/5, 2.6.9-rc3] generic irq subsystem, x64 port Ingo Molnar
2004-10-01 20:48 ` [patch 4/5, 2.6.9-rc3] generic irq subsystem, ppc port Ingo Molnar
2004-10-01 20:49 ` [patch 5/5, 2.6.9-rc3] generic irq subsystem, ppc64 port Ingo Molnar
[not found] ` <20041001143332.7e3a5aba.akpm@osdl.org>
[not found] ` <Pine.LNX.4.61.0410091550300.2870@musoma.fsmlabs.com>
2004-10-11 8:19 ` [PATCH] i386 CPU hotplug updated for -mm Zwane Mwaikambo
2004-10-12 5:59 ` Nathan Lynch
2004-10-12 6:04 ` Ingo Molnar [this message]
2004-10-12 14:16 ` Nathan Lynch
2004-10-12 14:38 ` Zwane Mwaikambo
2004-10-12 6:23 ` Dave Hansen
2004-10-12 14:47 ` Zwane Mwaikambo
2004-10-18 15:10 ` Pavel Machek
2004-10-21 14:47 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041012060410.GE1479@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathanl@austin.ibm.com \
--cc=rusty@rustcorp.com.au \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox