From: Jakub Jelinek <jakub@redhat.com>
To: Arun Sharma <arun.sharma@intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Support ia32 exec domains without CONFIG_IA32_SUPPORT
Date: Thu, 14 Oct 2004 04:50:05 -0400 [thread overview]
Message-ID: <20041014085003.GM31909@devserv.devel.redhat.com> (raw)
In-Reply-To: <416C5ECF.6060402@intel.com>
On Tue, Oct 12, 2004 at 03:46:39PM -0700, Arun Sharma wrote:
> --- linux-2.6-cvs/fs/namei.c 2 Oct 2004 17:59:55 -0000 1.110
> +++ linux-2.6-cvs/fs/namei.c 8 Oct 2004 18:14:11 -0000
> @@ -897,7 +897,7 @@
> return 1;
> }
>
> -void set_fs_altroot(void)
> +int set_fs_altroot(const char __user *altroot)
> {
> char *emul = __emul_prefix();
I think you should change this to char *emul;
> struct nameidata nd;
> @@ -905,12 +905,20 @@
> struct dentry *dentry = NULL, *olddentry;
> int err;
>
> + if (altroot) {
> + emul = getname(altroot);
> + if (IS_ERR(emul))
> + return PTR_ERR(emul);
> + }
> +
and add here
else
emul = __emul_prefix();
There is no point in calling __emul_prefix () when it will be thrown away.
Jakub
next prev parent reply other threads:[~2004-10-14 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41643EC0.1010505@intel.com>
[not found] ` <20041007142710.A12688@infradead.org>
[not found] ` <4165D4C9.2040804@intel.com>
[not found] ` <mailman.1097223239.25078@unix-os.sc.intel.com>
[not found] ` <41671696.1060706@intel.com>
[not found] ` <mailman.1097403036.11924@unix-os.sc.intel.com>
2004-10-11 21:05 ` [PATCH] Support ia32 exec domains without CONFIG_IA32_SUPPORT Arun Sharma
2004-10-12 21:50 ` David Woodhouse
2004-10-12 22:46 ` Arun Sharma
2004-10-13 22:27 ` Arun Sharma
2004-10-14 7:32 ` David Mosberger
2004-10-14 8:25 ` David Woodhouse
2004-10-14 8:50 ` Jakub Jelinek [this message]
2004-10-14 17:53 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041014085003.GM31909@devserv.devel.redhat.com \
--to=jakub@redhat.com \
--cc=arun.sharma@intel.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox