From: Dave Jones <davej@redhat.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Brian Gerst <bgerst@didntduck.org>,
"Martin K. Petersen" <mkp@wildopensource.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
akpm@osdl.org, tony.luck@intel.com
Subject: Re: [PATCH] General purpose zeroed page slab
Date: Thu, 14 Oct 2004 14:49:15 -0400 [thread overview]
Message-ID: <20041014184915.GE18321@redhat.com> (raw)
In-Reply-To: <20041014173637.GQ16153@parcelfarce.linux.theplanet.co.uk>
On Thu, Oct 14, 2004 at 06:36:37PM +0100, Matthew Wilcox wrote:
> On Thu, Oct 14, 2004 at 01:30:21PM -0400, Brian Gerst wrote:
> > This doesn't work as you expect it does. The constructor is only called
> > when a new slab is created, for each new object on the slab. It is
> > _not_ run again when an object is freed. So if a page is freed then
> > immediately reallocated it will contain garbage.
>
> The user is responsible for zeroing the page before handing it back to
> the slab allocator.
That sounds like an accident waiting to happen.
How about a CONFIG_DEBUG option to check its zeroed on free ?
Dave
next prev parent reply other threads:[~2004-10-14 18:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 16:50 [PATCH] General purpose zeroed page slab Martin K. Petersen
2004-10-14 17:30 ` Brian Gerst
2004-10-14 17:36 ` Matthew Wilcox
2004-10-14 18:49 ` Dave Jones [this message]
2004-10-14 19:08 ` Denis Vlasenko
2004-10-14 19:47 ` Matthew Wilcox
2004-10-14 18:04 ` Andi Kleen
2004-10-14 23:36 ` Adam Heath
2004-10-15 1:18 ` Andi Kleen
2004-10-18 18:06 ` Martin K. Petersen
2004-10-18 18:42 ` Matthew Wilcox
2004-10-18 18:54 ` Martin K. Petersen
2004-10-18 19:06 ` Andi Kleen
2004-10-18 21:06 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2004-10-18 19:03 Luck, Tony
2004-10-18 19:14 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041014184915.GE18321@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=bgerst@didntduck.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mkp@wildopensource.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox