From: Matt Mackall <mpm@selenic.com>
To: Christoph Hellwig <hch@infradead.org>,
Roman Zippel <zippel@linux-m68k.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] move semaphore definitions to waitlock_types.h
Date: Thu, 14 Oct 2004 18:40:20 -0500 [thread overview]
Message-ID: <20041014234019.GZ5414@waste.org> (raw)
In-Reply-To: <20041014220554.GA14731@infradead.org>
On Thu, Oct 14, 2004 at 11:05:54PM +0100, Christoph Hellwig wrote:
> On Thu, Oct 14, 2004 at 11:45:20PM +0200, Roman Zippel wrote:
> >
> > This moves the definition and initializer of semaphore, rw_semaphore and
> > wait queue structures to waitlock_types.h.
>
[...]
> But I must say I really hate this kind of separation as it makes
> the code rather hard to follow.
You do? This is essentially the same separation as putting code in .c files and
data definitions in .h files.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2004-10-14 23:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 21:45 [PATCH 4/4] move semaphore definitions to waitlock_types.h Roman Zippel
2004-10-14 22:05 ` Christoph Hellwig
2004-10-14 22:26 ` Roman Zippel
2004-10-14 23:40 ` Matt Mackall [this message]
2004-10-14 22:09 ` William Lee Irwin III
2004-10-14 22:27 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041014234019.GZ5414@waste.org \
--to=mpm@selenic.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox