From: Dave Jones <davej@redhat.com>
To: Daniele Pizzoni <auouo@tin.it>
Cc: lkml <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@lists.osdl.org>,
pazke@orbita.don.sitek.net
Subject: Re: janitoring printk with no KERN_ constants, kill all defaults?
Date: Fri, 15 Oct 2004 11:46:58 -0400 [thread overview]
Message-ID: <20041015154658.GD23638@redhat.com> (raw)
In-Reply-To: <1097855099.3004.64.camel@pdp11.tsho.org>
On Fri, Oct 15, 2004 at 05:44:59PM +0200, Daniele Pizzoni wrote:
> I ask, what rationale there is behind checking all printks to include
> the "appropriate" constant? Should then we make printk fail when called
> without KERN_ constant? Or can I force with a sed script all defaulted
> printk to KERN_WARNING?
No. Consider this..
printk (KERN_INFO "blah blah ");
if (foo)
printk ("%s", stringptr);
else
printk ("%d", number);
printk ("\n");
There's nothing wrong with any of those printk's, so you
cannot do the checks you mention above.
Dave
next prev parent reply other threads:[~2004-10-15 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 15:44 janitoring printk with no KERN_ constants, kill all defaults? Daniele Pizzoni
2004-10-15 15:46 ` Dave Jones [this message]
2004-10-15 17:20 ` Daniele Pizzoni
2004-10-15 16:17 ` [KJ] " Nishanth Aravamudan
-- strict thread matches above, loose matches on Subject: below --
2004-10-15 17:06 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041015154658.GD23638@redhat.com \
--to=davej@redhat.com \
--cc=auouo@tin.it \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@orbita.don.sitek.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox