From: Martin Waitz <tali@admingilde.org>
To: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc4-mm1: initramfs build fix
Date: Sun, 17 Oct 2004 18:15:54 +0200 [thread overview]
Message-ID: <20041017161554.GD10532@admingilde.org> (raw)
In-Reply-To: <20041011032502.299dc88d.akpm@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
hi :)
CONFIG_INITRAMFS_SOURCE may be empty which confuses 'test'.
So we have to quote it properly.
Signed-off-by: Martin Waitz <tali@admingilde.org>
Index: linux-2.6/usr/Makefile
===================================================================
--- linux-2.6.orig/usr/Makefile 2004-10-17 16:06:58.430886734 +0200
+++ linux-2.6/usr/Makefile 2004-10-17 16:07:56.185444167 +0200
@@ -25,14 +25,14 @@
quiet_cmd_gen_list = GEN_INITRAMFS_LIST $@
cmd_gen_list = $(shell \
- if test -f $(CONFIG_INITRAMFS_SOURCE); then \
- if [ $(CONFIG_INITRAMFS_SOURCE) != $@ ]; then \
- echo 'cp -f $(CONFIG_INITRAMFS_SOURCE) $@'; \
+ if test -f "$(CONFIG_INITRAMFS_SOURCE)"; then \
+ if [ "$(CONFIG_INITRAMFS_SOURCE)" != $@ ]; then \
+ echo 'cp -f "$(CONFIG_INITRAMFS_SOURCE)" $@'; \
else \
echo 'echo Using shipped $@'; \
fi; \
- elif test -d $(CONFIG_INITRAMFS_SOURCE); then \
- echo 'scripts/gen_initramfs_list.sh $(CONFIG_INITRAMFS_SOURCE) > $@'; \
+ elif test -d "$(CONFIG_INITRAMFS_SOURCE)"; then \
+ echo 'scripts/gen_initramfs_list.sh "$(CONFIG_INITRAMFS_SOURCE)" > $@'; \
else \
echo 'echo Using shipped $@'; \
fi)
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-10-17 16:22 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 10:25 2.6.9-rc4-mm1 Andrew Morton
2004-10-11 11:29 ` 2.6.9-rc4-mm1 Eyal Lebedinsky
2004-10-11 11:37 ` 2.6.9-rc4-mm1 Tim Cambrant
2004-10-11 11:38 ` 2.6.9-rc4-mm1 Nick Piggin
2004-10-11 19:13 ` 2.6.9-rc4-mm1 Andrew Morton
2004-10-11 22:57 ` 2.6.9-rc4-mm1 Nick Piggin
2004-10-11 11:43 ` 2.6.9-rc4-mm1 Brice Goglin
2004-10-11 12:30 ` 2.6.9-rc4-mm1 Con Kolivas
2004-10-11 13:17 ` 2.6.9-rc4-mm1 Alan Cox
2004-10-11 14:23 ` 2.6.9-rc4-mm1 Con Kolivas
2004-10-11 14:30 ` 2.6.9-rc4-mm1 J.A. Magallon
2004-10-11 12:44 ` Unable to handle kernel paging request at virtual address 0000ed9c [was Re: 2.6.9-rc4-mm1] Ramón Rey Vicente
2004-10-11 13:19 ` Tim Cambrant
2004-10-11 13:34 ` Ramón Rey Vicente
2004-10-11 13:43 ` 2.6.9-rc4-mm1 Jack Byer
2004-10-11 21:58 ` 2.6.9-rc4-mm1 Andrew Morton
2004-10-11 22:10 ` 2.6.9-rc4-mm1 Tom Rini
2004-10-11 23:14 ` 2.6.9-rc4-mm1 Thayne Harbaugh
2004-10-12 0:32 ` 2.6.9-rc4-mm1 Jack Byer
2004-10-11 14:22 ` 2.6.9-rc4-mm1 J.A. Magallon
2004-10-11 14:23 ` 2.6.9-rc4-mm1 Eyal Lebedinsky
2004-10-11 15:33 ` 2.6.9-rc4-mm1 [missing i2o patch in the main patch] syrius.ml
2004-10-11 15:47 ` 2.6.9-rc4-mm1 Zwane Mwaikambo
2004-10-11 15:49 ` 2.6.9-rc4-mm1 Andi Kleen
2004-10-11 15:58 ` 2.6.9-rc4-mm1 Zwane Mwaikambo
2004-10-11 16:01 ` 2.6.9-rc4-mm1 Andi Kleen
2004-10-11 19:55 ` 2.6.9-rc4-mm1 Andrew Morton
2004-10-11 21:52 ` 2.6.9-rc4-mm1 Andi Kleen
2004-10-12 14:24 ` 2.6.9-rc4-mm1 Zwane Mwaikambo
2004-10-11 16:08 ` 2.6.9-rc4-mm1 Jeff Garzik
2004-10-11 22:38 ` 2.6.9-rc4-mm1 Lee Revell
2004-10-11 17:57 ` 2.6.9-rc4-mm1 (compile stats) John Cherry
2004-10-11 18:51 ` 2.6.9-rc4-mm1 Brice Goglin
2004-10-11 20:18 ` 2.6.9-rc4-mm1 Adrian Bunk
2004-10-11 20:15 ` [patch] 2.6.9-rc4-mm1: ALSA compile error with KMOD=n Adrian Bunk
2004-10-12 14:25 ` [patch] 2.6.9-rc4-mm1: USB compile error with PROC_FS=n Adrian Bunk
2004-10-12 16:34 ` Greg KH
2004-10-12 16:36 ` Greg KH
2004-10-12 18:49 ` 2.6.9-rc4-mm1: CRASH_DUMP " Adrian Bunk
2004-10-13 14:30 ` Hariprasad Nellitheertha
2004-10-13 7:42 ` 2.6.9-rc4-mm1 Wen-chien Jesse Sung
2004-10-13 8:16 ` 2.6.9-rc4-mm1 Hideo AOKI
2004-10-13 13:07 ` 2.6.9-rc4-mm1 Jesse Stockall
2004-10-13 13:19 ` 2.6.9-rc4-mm1 Mathieu Segaud
2004-10-13 13:34 ` 2.6.9-rc4-mm1 Jesse Stockall
2004-10-13 17:27 ` 2.6.9-rc4-mm1 Peter Adebahr
2004-10-14 4:42 ` 2.6.9-rc4-mm1 Hiroyuki KAMEZAWA
2004-10-14 4:50 ` 2.6.9-rc4-mm1 Andrew Morton
2004-10-14 5:23 ` 2.6.9-rc4-mm1 Hiroyuki KAMEZAWA
2004-10-14 17:50 ` 2.6.9-rc4-mm1 Christian Borntraeger
2004-10-15 7:08 ` 2.6.9-rc4-mm1 J.A. Magallon
2004-10-15 16:47 ` 2.6.9-rc4-mm1 Lee Revell
2004-10-17 16:15 ` Martin Waitz [this message]
2004-10-17 17:29 ` 2.6.9-rc4-mm1: initramfs build fix [u] Martin Schlemmer [c]
2004-10-17 21:33 ` Sam Ravnborg
2004-10-17 20:12 ` Martin Schlemmer [c]
2004-10-18 19:26 ` Martin Schlemmer [c]
2004-10-20 12:09 ` [patch] 2.6.9-rc4-mm1: compile error with BLK_DEV_IDEDMA=n Adrian Bunk
2004-10-20 14:08 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041017161554.GD10532@admingilde.org \
--to=tali@admingilde.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox