From: Ingo Molnar <mingo@elte.hu>
To: Daniele Pizzoni <auouo@tin.it>
Cc: kernel-janitors <kernel-janitors@lists.osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/8] replacing/fixing printk with pr_debug/pr_info in arch/i386 - intro
Date: Sun, 17 Oct 2004 18:19:53 +0200 [thread overview]
Message-ID: <20041017161953.GA24810@elte.hu> (raw)
In-Reply-To: <1098031764.3023.45.camel@pdp11.tsho.org>
* Daniele Pizzoni <auouo@tin.it> wrote:
> Hello, I'm going to post a series of small janitorial patches focused on
> 1) replacing DPRINTK-style macros with pr_debug from kernel.h
> 2) replacing printk(KERN_INFO ...) with pr_info(...)
> 3) fixing _obvious_ inconsistencies of printk levels as:
>
> printk(KERN_INFO "Start... ");
> ...
> printk("Ok!\n");
1) be careful, there is no inconsistency here. It's a printk that doesnt
end in a "\n" in the first line.
2) i dont like the pr_print name at all. What's wrong with Dprintk or
dprintk? Just define them in kernel.h, this will also make your patch
much smaller.
Ingo
next prev parent reply other threads:[~2004-10-17 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-17 17:10 [PATCH 0/8] replacing/fixing printk with pr_debug/pr_info in arch/i386 - intro Daniele Pizzoni
2004-10-17 16:19 ` Ingo Molnar [this message]
2004-10-17 18:10 ` Geert Uytterhoeven
2004-10-17 18:23 ` Joe Perches
2004-10-17 18:34 ` Geert Uytterhoeven
2004-10-18 2:41 ` Daniele Pizzoni
2004-10-18 10:36 ` Ingo Molnar
2004-10-18 12:59 ` Daniele Pizzoni
[not found] <2QlVm-7u4-13@gated-at.bofh.it>
[not found] ` <2Qmok-7KK-1@gated-at.bofh.it>
2004-10-17 20:26 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041017161953.GA24810@elte.hu \
--to=mingo@elte.hu \
--cc=auouo@tin.it \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox