From: Andrew Morton <akpm@osdl.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@SteelEye.com,
torvalds@osdl.org, linux-scsi@vger.kernel.org, willy@debian.org,
linux1394-devel@lists.sourceforge.net
Subject: Re: [BK PATCH] SCSI updates for 2.6.9
Date: Mon, 18 Oct 2004 22:05:21 -0700 [thread overview]
Message-ID: <20041018220521.3555fb7b.akpm@osdl.org> (raw)
In-Reply-To: <200410182341.13648.dtor_core@ameritech.net>
Dmitry Torokhov <dtor_core@ameritech.net> wrote:
>
> On Monday 18 October 2004 05:03 pm, James Bottomley wrote:
>
> > Matthew Wilcox:
> > o Add SPI-5 constants to scsi.h
>
> This breaks Firewire SBP2 build:
Insert grumpy comment wrt testing in -mm.
> CC [M] drivers/ieee1394/sbp2.o
> In file included from drivers/ieee1394/sbp2.c:78:
> drivers/ieee1394/sbp2.h:61:1: warning: "ABORT_TASK_SET" redefined
> In file included from drivers/scsi/scsi.h:31,
> from drivers/ieee1394/sbp2.c:67:
> include/scsi/scsi.h:255:1: warning: this is the location of the previous definition
> In file included from drivers/ieee1394/sbp2.c:78:
> drivers/ieee1394/sbp2.h:62:1: warning: "LOGICAL_UNIT_RESET" redefined
> In file included from drivers/scsi/scsi.h:31,
> from drivers/ieee1394/sbp2.c:67:
> include/scsi/scsi.h:267:1: warning: this is the location of the previous definition
>
> It looks like firewire has its own set of commands with conflicting names.
> Who should win?
Probably 1394 should be using less generic-looking names.
I assume this patch broke drivers/s390/scsi/zfcp_def.h as well.
next prev parent reply other threads:[~2004-10-19 5:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-18 22:03 [BK PATCH] SCSI updates for 2.6.9 James Bottomley
2004-10-19 0:30 ` K.R. Foley
2004-10-19 4:41 ` Dmitry Torokhov
2004-10-19 5:05 ` Andrew Morton [this message]
2004-10-19 5:12 ` Dmitry Torokhov
2004-10-19 7:13 ` Linus Torvalds
2004-10-19 7:42 ` Ben Collins
2004-10-19 8:03 ` Jens Axboe
2004-10-19 13:54 ` James Bottomley
2004-10-19 16:17 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041018220521.3555fb7b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=James.Bottomley@SteelEye.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=torvalds@osdl.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox