Re: [BK PATCH] SCSI updates for 2.6.9

James Bottomley
2004-10-19T13:55:17Z

On Tue, 2004-10-19 at 02:13, Linus Torvalds wrote:
> does this look ok to you?
>
> Arguably the SCSI layer should also have proper prefixes for its constants
> - and in fact they do kind of exist as the GPCMD_xxx constants. Oh, well.
> Regardless, the sbp2 constants do look like they want prefixing..

We're slowly standardising at least some of our namespace problems.

The condition codes are all migrating to SAM_STAT_ prefix, so
CHECK_CONDITION becomes SAM_STAT_CHECK_CONDITION (and gets shifted in
the process).

We still have a nasty namespace pollution problem on the SCSI commands
though and cleaning this up is problematic since they permeate not just
SCSI but large areas of other drivers as well.

James