Re: [BK PATCH] SCSI updates for 2.6.9

Dmitry Torokhov
2004-10-19T04:44:50Z

On Monday 18 October 2004 05:03 pm, James Bottomley wrote:

> Matthew Wilcox:
> o Add SPI-5 constants to scsi.h

This breaks Firewire SBP2 build:

CC [M] drivers/ieee1394/sbp2.o
In file included from drivers/ieee1394/sbp2.c:78:
drivers/ieee1394/sbp2.h:61:1: warning: "ABORT_TASK_SET" redefined
In file included from drivers/scsi/scsi.h:31,
from drivers/ieee1394/sbp2.c:67:
include/scsi/scsi.h:255:1: warning: this is the location of the previous definition
In file included from drivers/ieee1394/sbp2.c:78:
drivers/ieee1394/sbp2.h:62:1: warning: "LOGICAL_UNIT_RESET" redefined
In file included from drivers/scsi/scsi.h:31,
from drivers/ieee1394/sbp2.c:67:
include/scsi/scsi.h:267:1: warning: this is the location of the previous definition

It looks like firewire has its own set of commands with conflicting names.
Who should win?

--
Dmitry