From: Tom Rini <trini@kernel.crashing.org>
To: Roland Dreier <roland@topspin.com>
Cc: sam@ravnborg.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc: fix build with O=$(output_dir)
Date: Tue, 19 Oct 2004 09:44:49 -0700 [thread overview]
Message-ID: <20041019164449.GF6298@smtp.west.cox.net> (raw)
In-Reply-To: <52is979pah.fsf@topspin.com>
On Mon, Oct 18, 2004 at 11:48:22PM -0700, Roland Dreier wrote:
> Recent changes to arch/ppc/boot/lib/Makefile cause
>
> CC arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o
> Assembler messages:
> FATAL: can't create arch/ppc/boot/lib/../../../../lib/zlib_inflate/infblock.o: No such file or directory
>
> when building a ppc kernel using O=$(output_dir) with CONFIG_ZLIB_INFLATE=n,
> because the $(output_dir)/lib/zlib_inflate directory doesn't get created.
>
> This patch, which makes arch/ppc/boot/lib/Makefile create the
> directory if needed, is one fix for the problem.
IMHO, this is the uglier of the two fixes for the problem, as this means
you'll still be clobbering lib/zlib_inflate/*.o when ZLIB_INFLATE!=n.
The other is to go back to putting the object in $(O)/arch/ppc/boot/lib/
and copying the guts of the .c.o rule to arch/ppc/boot/lib/Makefile
Sam, any chance you've had time to think up a good fix to this? Thanks.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2004-10-19 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 6:48 [PATCH] ppc: fix build with O=$(output_dir) Roland Dreier
2004-10-19 16:44 ` Tom Rini [this message]
2004-10-19 18:14 ` [PATCH/take 2] " Roland Dreier
2004-10-19 18:29 ` Tom Rini
2004-10-19 18:58 ` Roland Dreier
2004-10-26 22:33 ` Sam Ravnborg
2004-10-31 22:39 ` Sam Ravnborg
2004-10-31 21:53 ` Tom Rini
[not found] <200410211910.i9LJAKjf029014@hera.kernel.org>
2004-10-21 20:29 ` [PATCH] " Tom Rini
2004-10-21 20:31 ` Tom Rini
2004-10-22 4:20 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041019164449.GF6298@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox