From: Andrew Morton <akpm@osdl.org>
To: jt@hpl.hp.com
Cc: jt@bougret.hpl.hp.com, davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6 IrDA] Stir driver usb reset fix
Date: Wed, 20 Oct 2004 15:53:49 -0700 [thread overview]
Message-ID: <20041020155349.4514de82.akpm@osdl.org> (raw)
In-Reply-To: <20041020010733.GJ12932@bougret.hpl.hp.com>
Jean Tourrilhes <jt@bougret.hpl.hp.com> wrote:
>
> o [CORRECT] stir4200 - get rid of reset on speed change
> The Sigmatel 4200 doesn't accept the address setting which gets done on
> USB reset. The USB core recently changed to resend address (or
> something like that), so usb_reset_device is failing.
This needs fixups due to competing changes. Please review:
From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
From: Stephen Hemminger
o [CORRECT] stir4200 - get rid of reset on speed change The Sigmatel 4200
doesn't accept the address setting which gets done on USB reset. The USB
core recently changed to resend address (or something like that), so
usb_reset_device is failing.
The device works without doing the USB reset on speed change, it just
will be less robust in recovering when things get wedged (like coming
out of FIR mode).
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/drivers/net/irda/stir4200.c | 3 ---
1 files changed, 3 deletions(-)
diff -puN drivers/net/irda/stir4200.c~irda-stir-driver-usb-reset-fix drivers/net/irda/stir4200.c
--- 25/drivers/net/irda/stir4200.c~irda-stir-driver-usb-reset-fix Wed Oct 20 15:51:39 2004
+++ 25-akpm/drivers/net/irda/stir4200.c Wed Oct 20 15:52:50 2004
@@ -528,11 +528,8 @@ static int change_speed(struct stir_cb *
err = rc;
goto out;
}
- err = usb_reset_device(stir->usbdev);
if (rc)
usb_unlock_device(stir->usbdev);
- if (err)
- goto out;
/* Reset modulator */
err = write_reg(stir, REG_CTRL1, CTRL1_SRESET);
_
next prev parent reply other threads:[~2004-10-20 22:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 1:07 [PATCH 2.6 IrDA] Stir driver usb reset fix Jean Tourrilhes
2004-10-20 22:53 ` Andrew Morton [this message]
2004-10-20 22:54 ` Jean Tourrilhes
2004-10-21 4:09 ` David S. Miller
2004-10-21 4:29 ` Andrew Morton
2004-10-21 5:02 ` shemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020155349.4514de82.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jt@bougret.hpl.hp.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox