From: Andrew Morton <akpm@osdl.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: Am I paranoid or is everyone out to break my kernel builds (Breakage in drivers/pcmcia)
Date: Thu, 21 Oct 2004 02:31:35 -0700 [thread overview]
Message-ID: <20041021023135.074c7988.akpm@osdl.org> (raw)
In-Reply-To: <20041021100903.A3089@flint.arm.linux.org.uk>
Russell King <rmk+lkml@arm.linux.org.uk> wrote:
>
> It would appear that this change:
>
> -module_param_array(irq_list, int, irq_list_count, 0444);
> +module_param_array(irq_list, int, &irq_list_count, 0444);
>
> given:
>
> static int irq_list[16];
> static int irq_list_count;
>
> breaks PCMCIA drivers. Why?
>
> #define module_param_array(name, type, num, perm) \
> module_param_array_named(name, name, type, num, perm)
>
> #define module_param_array_named(name, array, type, num, perm) \
> static struct kparam_array __param_arr_##name \
> = { ARRAY_SIZE(array), &num, param_set_##type, param_get_##type,\
> sizeof(array[0]), array }; \
> module_param_call(name, param_array_set, param_array_get, \
> &__param_arr_##name, perm)
>
> Take special note of the '&' before 'num' in the above initialiser, and
> check the structure:
Something's out of whack with your tree. You should have:
#define module_param_array_named(name, array, type, nump, perm) \
static struct kparam_array __param_arr_##name \
= { ARRAY_SIZE(array), nump, param_set_##type, param_get_##type,\
sizeof(array[0]), array }; \
module_param_call(name, param_array_set, param_array_get, \
&__param_arr_##name, perm)
next prev parent reply other threads:[~2004-10-21 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 9:09 Am I paranoid or is everyone out to break my kernel builds (Breakage in drivers/pcmcia) Russell King
2004-10-21 9:31 ` Andrew Morton [this message]
2004-10-21 9:50 ` Russell King
2004-10-21 17:02 ` Andrew Morton
2004-10-21 23:46 ` Rusty Russell
2004-10-21 9:40 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041021023135.074c7988.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox