From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@osdl.org>
Subject: Am I paranoid or is everyone out to break my kernel builds (Breakage in drivers/pcmcia)
Date: Thu, 21 Oct 2004 10:09:03 +0100 [thread overview]
Message-ID: <20041021100903.A3089@flint.arm.linux.org.uk> (raw)
It would appear that this change:
-module_param_array(irq_list, int, irq_list_count, 0444);
+module_param_array(irq_list, int, &irq_list_count, 0444);
given:
static int irq_list[16];
static int irq_list_count;
breaks PCMCIA drivers. Why?
#define module_param_array(name, type, num, perm) \
module_param_array_named(name, name, type, num, perm)
#define module_param_array_named(name, array, type, num, perm) \
static struct kparam_array __param_arr_##name \
= { ARRAY_SIZE(array), &num, param_set_##type, param_get_##type,\
sizeof(array[0]), array }; \
module_param_call(name, param_array_set, param_array_get, \
&__param_arr_##name, perm)
Take special note of the '&' before 'num' in the above initialiser, and
check the structure:
struct kparam_array
{
unsigned int max;
unsigned int *num;
param_set_fn set;
param_get_fn get;
unsigned int elemsize;
void *elem;
};
Therefore, module_param_array() does _NOT_ take a pointer to an integer.
Rusty - please fix.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next reply other threads:[~2004-10-21 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 9:09 Russell King [this message]
2004-10-21 9:31 ` Am I paranoid or is everyone out to break my kernel builds (Breakage in drivers/pcmcia) Andrew Morton
2004-10-21 9:50 ` Russell King
2004-10-21 17:02 ` Andrew Morton
2004-10-21 23:46 ` Rusty Russell
2004-10-21 9:40 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041021100903.A3089@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox