Re: [patch] 2.6.9-ac1: invalid SUBLEVEL

[Han Boetes <han@mijncomputer.nl>]

Alan Cox wrote:
> On Iau, 2004-10-21 at 13:49, Adrian Bunk wrote:
> >  VERSION = 2
> >  PATCHLEVEL = 6
> > -SUBLEVEL = 9-ac1
> > -EXTRAVERSION =
> > +SUBLEVEL = 9
> > +EXTRAVERSION = -ac1
> >  NAME=AC 1
>
> Doh I'm -amazed- that worked for me. Fixed in my tree

Here is some old shell-code I wrote for my kernel updating script: It
was especially written because you tend to forget this.

test_version () {
    # Sometimes Alan forgets to update the EXTRAVERSION in the Makefile;
    # then you destroy the previous version and the script fails :S
    cd $pwd/linux-$latest_stable
    # if EXTRAVERSION is for mm but not the current one.
    if [ -z "$(grep "EXTRAVERSION = -$mm_rest" Makefile)" \
        -a -z "$(grep "EXTRAVERSION = .*mm" Makefile)" ]; then
        warning 'Warning: I had to edit the versionnumber in the Makefile!'
        grep "EXTRAVERSION =" Makefile
        perl -pi -e "s#^EXTRAVERSION.*\n#EXTRAVERSION = -$mm_rest\n#" \
            Makefile || error
        grep "EXTRAVERSION =" Makefile
    fi
}

> I'll go and hide in a corner for a bit.

I think it is a better idea you add some checks to the script you use to
generate that patch.



# Han