From: Pavel Machek <pavel@ucw.cz>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: __init & __initdata during resume
Date: Fri, 22 Oct 2004 09:54:54 +0200 [thread overview]
Message-ID: <20041022075454.GD8376@elf.ucw.cz> (raw)
In-Reply-To: <41788761.8020508@osdl.org>
Hi!
> 'make buildcheck' reports:
> Error: ./arch/x86_64/ia32/syscall32.o .text refers to 0000000000000002
> R_X86_64_PC32 .init.data+0x000000000000152b
> Error: ./arch/x86_64/ia32/syscall32.o .text refers to 0000000000000017
> R_X86_64_PC32 .init.data+0x000000000000152c
>
>
> I'm looking at a recent (2 weeks) changeset:
> [PATCH] Fix random crashes in x86-64 swsusp
>
> http://linux.bkbits.net:8080/linux-2.5/cset@4166a52aYzzfOE3F63Kkb966K2Qz3g?nav=index.html|src/|src/arch|src/arch/x86_64|src/arch/x86_64/ia32|related/arch/x86_64/ia32/syscall32.c
>
> in which this change was made:
>
> -void __init syscall32_cpu_init(void)
> +/* May not be __init: called during resume */
> +void syscall32_cpu_init(void)
>
> but syscall32_cpu_init() uses <use_sysenter>, which is:
> static int use_sysenter __initdata = -1;
>
> so the question is: does that "__initdata" need to removed also?
Yes, I'm afraid that I overlooked that one.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
prev parent reply other threads:[~2004-10-22 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 4:06 __init & __initdata during resume Randy.Dunlap
2004-10-22 7:54 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022075454.GD8376@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox