From: Andi Kleen <ak@suse.de>
To: Andreas Kleen <ak@suse.de>,
torvalds@osdl.org, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 2/17] Generic backward compatibility includes for 4level
Date: Mon, 25 Oct 2004 18:06:06 +0200 [thread overview]
Message-ID: <20041025160606.GA26306@verdi.suse.de> (raw)
In-Reply-To: <20041025103926.A31632@flint.arm.linux.org.uk>
On Mon, Oct 25, 2004 at 10:39:26AM +0100, Russell King wrote:
> On Mon, Oct 25, 2004 at 09:23:49AM +0200, Andreas Kleen wrote:
> > +/* Included by architectures that don't have a fourth page table level.
> > +
> > + pml4 is simply casted to pgd */
> > +
> > +#define pml4_ERROR(x)
>
> Don't we normally add do { } while (0) after empty macros which look like
> a function?
iirc Rusty tried to come up with an example some time ago where it actually
made a difference, but failed. But I can change it.
-Andi
next prev parent reply other threads:[~2004-10-25 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 7:23 [PATCH 2/17] Generic backward compatibility includes for 4level Andreas Kleen
2004-10-25 9:39 ` Russell King
2004-10-25 16:06 ` Andi Kleen [this message]
2004-10-25 16:50 ` Arjan van de Ven
2004-10-25 17:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041025160606.GA26306@verdi.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox