From: Andrea Arcangeli <andrea@novell.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Rik van Riel <riel@redhat.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: lowmem_reserve (replaces protection)
Date: Tue, 26 Oct 2004 06:04:29 +0200 [thread overview]
Message-ID: <20041026040429.GW14325@dualathlon.random> (raw)
In-Reply-To: <417DC8F2.7000902@yahoo.com.au>
On Tue, Oct 26, 2004 at 01:48:02PM +1000, Nick Piggin wrote:
> I see classzone_idx snuck in, can we leave that as alloc_type please?
when I wrote that code in 2.4 it was called class_idx. Just to show it
was not an opaque type, in this 2.6 I called it classzone_idx but it's
the same as class_idx. If you feel classzone_idx is too long I'm sure
fine to rename to class_idx like plain 2.4.
The reason I renamed it is that alloc_type tells nothing to who's
reading the code. That value in the opaque "alloc_type" variable, is
really the classzone_idx that identify the classzone we have to allocate
memory from. Classzone 2 means "all ram is good", classzone 2 means
"zone-normal + zone-dma is good", classzone 0 means "zone-dma is good".
alloc_type means very very little to me, calling it with a meaningful
name made the code more readable for me. gfp_mask describes other alloc
types as well that are not less singificant than the classzone_idx, so I
don't see why we should go back to the opaque variable name when we can
have a more descriptive one.
I'm not going to nitpick further on this detail though, all I care about
is the asm generated and not breaking ABIs with userspace (i.e. at least
one forced rename to the sysctl).
thanks for the review!
next prev parent reply other threads:[~2004-10-26 4:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 17:01 lowmem_reserve (replaces protection) Andrea Arcangeli
2004-10-26 1:48 ` Rik van Riel
2004-10-26 1:58 ` Andrea Arcangeli
2004-10-26 3:48 ` Nick Piggin
2004-10-26 4:04 ` Andrea Arcangeli [this message]
2004-10-26 4:17 ` Nick Piggin
2004-10-27 0:25 ` Andrea Arcangeli
2004-10-27 0:42 ` Andrew Morton
2004-10-27 0:48 ` Andrea Arcangeli
2004-10-27 2:06 ` Nick Piggin
2004-10-28 0:26 ` Andrea Arcangeli
2004-10-27 0:31 ` Rik van Riel
2004-10-27 0:54 ` Andrea Arcangeli
2004-10-27 0:56 ` Andrea Arcangeli
2004-10-27 1:35 ` Andrea Arcangeli
2004-10-27 2:08 ` Andrew Morton
2004-10-27 2:31 ` Andrea Arcangeli
2004-10-27 2:56 ` Nick Piggin
2004-10-27 1:00 ` Rik van Riel
2004-10-27 1:10 ` Andrea Arcangeli
2004-10-27 2:05 ` Nick Piggin
2004-10-27 2:29 ` Andrea Arcangeli
2004-10-27 3:01 ` Nick Piggin
2004-10-27 3:23 ` Andrea Arcangeli
2004-10-27 3:34 ` Nick Piggin
2004-10-27 3:43 ` Andrew Morton
2004-10-27 4:44 ` Andrea Arcangeli
2004-10-27 4:51 ` Rik van Riel
2004-10-27 5:05 ` Andrea Arcangeli
2004-10-27 5:50 ` Nick Piggin
2004-10-27 5:33 ` Andrew Morton
2004-10-27 6:11 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041026040429.GW14325@dualathlon.random \
--to=andrea@novell.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox