public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: <sezeroz@ttnet.net.tr>
To: <linux-kernel@vger.kernel.org>
Cc: <marcelo.tosatti@cyclades.com>
Subject: 2.4.28-rc1, more lost patches [3/10]
Date: Wed, 27 Oct 2004 12:33:52 +0300	[thread overview]
Message-ID: <20041027093352.JYEB6935.fep01.ttnet.net.tr@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 68 bytes --]


[3/10] binfmt_elf memleak, missing parts of Oleg's patch. in 2.6.


[-- Attachment #2: binfmt_elf-memleak.patch --]
[-- Type: application/octet-stream, Size: 945 bytes --]

Oleg Drokin, missing parts from the patch posted at
http://marc.theaimsgroup.com/?l=linux-kernel&m=105103934631609&w=2

already in 2.6

diff -urN 27p2/fs/binfmt_elf.c 27p2.pac/fs/binfmt_elf.c
--- 27p2/fs/binfmt_elf.c	2004-04-14 16:05:40.000000000 +0300
+++ 27p2.pac/fs/binfmt_elf.c	2004-05-09 23:58:10.000000000 +0300
@@ -375,7 +375,6 @@
 	unsigned long text_data, elf_entry = ~0UL;
 	char * addr;
 	loff_t offset;
-	int retval;
 
 	current->mm->end_code = interp_ex->a_text;
 	text_data = interp_ex->a_text + interp_ex->a_data;
@@ -397,11 +396,9 @@
 	}
 
 	do_brk(0, text_data);
-	retval = -ENOEXEC;
 	if (!interpreter->f_op || !interpreter->f_op->read)
 		goto out;
-	retval = interpreter->f_op->read(interpreter, addr, text_data, &offset);
-	if (retval < 0)
+	if (interpreter->f_op->read(interpreter, addr, text_data, &offset) < 0)
 		goto out;
 	flush_icache_range((unsigned long)addr,
 	                   (unsigned long)addr + text_data);

                 reply	other threads:[~2004-10-27  9:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041027093352.JYEB6935.fep01.ttnet.net.tr@localhost \
    --to=sezeroz@ttnet.net.tr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox