public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Chris Wedgwood <cw@f00f.org>
Cc: Jens Axboe <axboe@suse.de>, Jeff Garzik <jgarzik@pobox.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH] Rename SECTOR_SIZE to BIO_SECTOR_SIZE
Date: Wed, 27 Oct 2004 15:27:33 -0500	[thread overview]
Message-ID: <20041027202733.GG28904@waste.org> (raw)
In-Reply-To: <20041027190523.GA19330@taniwha.stupidest.org>

On Wed, Oct 27, 2004 at 12:05:23PM -0700, Chris Wedgwood wrote:
> Rename (one of the uses of) SECTOR_SIZE to BIO_SECTOR_SIZE which is
> more appropriate.

> Index: cw-current/include/linux/ide.h
> ===================================================================
> --- cw-current.orig/include/linux/ide.h	2004-10-27 11:33:06.237319044 -0700
> +++ cw-current/include/linux/ide.h	2004-10-27 11:35:13.246711414 -0700
> @@ -202,8 +202,8 @@
>  #define PARTN_BITS	6	/* number of minor dev bits for partitions */
>  #define PARTN_MASK	((1<<PARTN_BITS)-1)	/* a useful bit mask */
>  #define MAX_DRIVES	2	/* per interface; 2 assumed by lots of code */
> -#define SECTOR_SIZE	512
> -#define SECTOR_WORDS	(SECTOR_SIZE / 4)	/* number of 32bit words per sector */
> +#define BIO_SECTOR_SIZE	512
> +#define SECTOR_WORDS	(BIO_SECTOR_SIZE / 4)	/* number of 32bit words per sector */
>  #define IDE_LARGE_SEEK(b1,b2,t)	(((b1) > (b2) + (t)) || ((b2) > (b1) + (t)))

So shouldn't this be in bio.h now?

-- 
Mathematics is the supreme nostalgia of our time.

  reply	other threads:[~2004-10-27 20:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27  6:08 [RFC] Rename SECTOR_SIZE to IDE_SECTOR_SIZE Chris Wedgwood
2004-10-27  6:47 ` Jeff Garzik
2004-10-27  6:55   ` Chris Wedgwood
2004-10-27  7:22     ` Jens Axboe
2004-10-27 19:05       ` [PATCH] Rename SECTOR_SIZE to BIO_SECTOR_SIZE Chris Wedgwood
2004-10-27 20:27         ` Matt Mackall [this message]
2004-10-27 20:29           ` Chris Wedgwood
2004-10-27 20:36             ` Bartlomiej Zolnierkiewicz
2004-10-27 20:45           ` J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041027202733.GG28904@waste.org \
    --to=mpm@selenic.com \
    --cc=axboe@suse.de \
    --cc=bzolnier@gmail.com \
    --cc=cw@f00f.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox