* [patch/Makefile] Fix cc-option call for xcompiles
@ 2004-10-27 23:18 Randolph Chung
2004-10-28 1:16 ` Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: Randolph Chung @ 2004-10-27 23:18 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
If an arch Makefile overrides CROSS_COMPILE (e.g. parisc, mips, ...)
then the cc-option call in the main Makefile uses the wrong compiler
to check for options.
Signed-off-by: Randolph Chung <tausq@debian.org>
Index: Makefile
===================================================================
RCS file: /var/cvs/linux-2.6/Makefile,v
retrieving revision 1.281
diff -u -p -r1.281 Makefile
--- Makefile 27 Oct 2004 21:23:19 -0000 1.281
+++ Makefile 27 Oct 2004 23:16:30 -0000
@@ -494,10 +494,10 @@ ifdef CONFIG_DEBUG_INFO
CFLAGS += -g
endif
+include $(srctree)/arch/$(ARCH)/Makefile
+
# warn about C99 declaration after statement
CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
-
-include $(srctree)/arch/$(ARCH)/Makefile
# Default kernel image to build when no specific target is given.
# KBUILD_IMAGE may be overruled on the commandline or
--
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch/Makefile] Fix cc-option call for xcompiles
2004-10-27 23:18 [patch/Makefile] Fix cc-option call for xcompiles Randolph Chung
@ 2004-10-28 1:16 ` Linus Torvalds
2004-10-28 5:17 ` Randolph Chung
0 siblings, 1 reply; 3+ messages in thread
From: Linus Torvalds @ 2004-10-28 1:16 UTC (permalink / raw)
To: Randolph Chung; +Cc: linux-kernel
On Wed, 27 Oct 2004, Randolph Chung wrote:
>
> Signed-off-by: Randolph Chung <tausq@debian.org>
>
> Index: Makefile
> ===================================================================
> RCS file: /var/cvs/linux-2.6/Makefile,v
> retrieving revision 1.281
> diff -u -p -r1.281 Makefile
> --- Makefile 27 Oct 2004 21:23:19 -0000 1.281
Can you please make your patches be -p1 based? With CVS, I think just
using "cvs diff -u ." should do it.
Otherwise I'll have to edit the patch to make it work with the tools (not
a big deal for a single file diff, but..)
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch/Makefile] Fix cc-option call for xcompiles
2004-10-28 1:16 ` Linus Torvalds
@ 2004-10-28 5:17 ` Randolph Chung
0 siblings, 0 replies; 3+ messages in thread
From: Randolph Chung @ 2004-10-28 5:17 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
> Can you please make your patches be -p1 based? With CVS, I think just
> using "cvs diff -u ." should do it.
well, cvs diff is what i use... but ok, i'll make it -p1...
Index: Makefile
===================================================================
RCS file: /var/cvs/linux-2.6/Makefile,v
retrieving revision 1.281
diff -u -p -r1.281 Makefile
--- linux-2.6/Makefile 27 Oct 2004 21:23:19 -0000 1.281
+++ linux-2.6/Makefile 27 Oct 2004 23:16:30 -0000
@@ -494,10 +494,10 @@ ifdef CONFIG_DEBUG_INFO
CFLAGS += -g
endif
+include $(srctree)/arch/$(ARCH)/Makefile
+
# warn about C99 declaration after statement
CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
-
-include $(srctree)/arch/$(ARCH)/Makefile
# Default kernel image to build when no specific target is given.
# KBUILD_IMAGE may be overruled on the commandline or
--
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-28 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-27 23:18 [patch/Makefile] Fix cc-option call for xcompiles Randolph Chung
2004-10-28 1:16 ` Linus Torvalds
2004-10-28 5:17 ` Randolph Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox