From: Greg KH <greg@kroah.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fw: [PATCH] Fix e100 suspend/resume w/ 2.6.10-rc1 and above (due to pci_save_state change)
Date: Thu, 28 Oct 2004 11:06:03 -0500 [thread overview]
Message-ID: <20041028160603.GA10538@kroah.com> (raw)
In-Reply-To: <4181094D.7020800@pobox.com>
On Thu, Oct 28, 2004 at 10:59:25AM -0400, Jeff Garzik wrote:
> Greg KH wrote:
> >Huh? How did changing the pci_save_state() api change anything? I
> >didn't change the pci core any, just made it easier to not have to
> >specify the storage location of the memory to save everything off on.
>
> That could have been accomplished by moving the saved-config data
> storage into struct pci_dev
We did that a while ago.
> but not changing pci_save_state() prototype...
That was the last piece. It also fixed up some odd bugs when it was
done.
Do we really want drivers to go back to have to declare the pci config
space themselves if they want to? What does that buy us?
I agree that Ben's comments are valid, but the recent patch doesn't
change anything that wasn't already being done.
thanks,
greg k-h
prev parent reply other threads:[~2004-10-28 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041028025536.5d9b1067.akpm@osdl.org>
2004-10-28 14:21 ` Fw: [PATCH] Fix e100 suspend/resume w/ 2.6.10-rc1 and above (due to pci_save_state change) Jeff Garzik
2004-10-28 14:29 ` Greg KH
2004-10-28 14:59 ` Jeff Garzik
2004-10-28 16:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028160603.GA10538@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox