The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: James Cleverdon <jamesclv@us.ibm.com>
Cc: Chris Wright <chrisw@osdl.org>, ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clustered apic patch missing APIC_DFR_CLUSTER def
Date: Thu, 28 Oct 2004 16:51:58 -0700	[thread overview]
Message-ID: <20041028165157.K2357@build.pdx.osdl.net> (raw)
In-Reply-To: <200410281635.23848.jamesclv@us.ibm.com>; from jamesclv@us.ibm.com on Thu, Oct 28, 2004 at 04:35:23PM -0700

* James Cleverdon (jamesclv@us.ibm.com) wrote:
> Hmmm...  The patch containing APIC_DFR_CLUSTER and friends went
> into the -mm tree in the June/July timeframe.  It must not have
> been pushed with the main cluster patch.

OK, looks like Andi just sent something similar (i dropped the l (ell), since
it looked meant to be only 32bit).

> You're right, we're using the generic version of
> cpu_present_to_apicid().  The cluster one can go.

This part resent (below).

thanks,
-chris

Remove cluster_cpu_present_to_apicid(), it's defined but not used anywhere.

Signed-off-by: Chris Wright <chrisw@osdl.org>

===== arch/x86_64/kernel/genapic_cluster.c 1.1 vs edited =====
--- 1.1/arch/x86_64/kernel/genapic_cluster.c	2004-10-28 00:39:50 -07:00
+++ edited/arch/x86_64/kernel/genapic_cluster.c	2004-10-28 11:18:10 -07:00
@@ -57,14 +57,6 @@
 	apic_write_around(APIC_LDR, val);
 }
 
-static int cluster_cpu_present_to_apicid(int mps_cpu)
-{
-	if ((unsigned)mps_cpu < NR_CPUS)
-		return (int)bios_cpu_apicid[mps_cpu];
-	else
-		return BAD_APICID;
-}
-
 /* Start with all IRQs pointing to boot CPU.  IRQ balancing will shift them. */
 
 static cpumask_t cluster_target_cpus(void)

      parent reply	other threads:[~2004-10-29  0:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-28 18:27 [PATCH] clustered apic patch missing APIC_DFR_CLUSTER def Chris Wright
2004-10-28 23:35 ` James Cleverdon
2004-10-28 23:38   ` Andi Kleen
2004-10-28 23:51   ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041028165157.K2357@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=ak@suse.de \
    --cc=jamesclv@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox