From: Pavel Machek <pavel@ucw.cz>
To: "Li, Shaohua" <shaohua.li@intel.com>
Cc: ncunningham@linuxmail.org,
Patrick Mochel <mochel@digitalimplant.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: time and suspending sysdevs [was Re: Fixing MTRR smp breakage and suspending sysdevs.]
Date: Fri, 29 Oct 2004 00:38:38 +0200 [thread overview]
Message-ID: <20041028223838.GA2319@elf.ucw.cz> (raw)
In-Reply-To: <20041027100046.GB26265@elf.ucw.cz>
Hi!
> > >One thing I have noticed is that by adding the sysdev suspend/resume
> > >calls, I've gained a few seconds delay. I'll see if I can track down
> > the
> > >cause.
Sysdev suspend/resume calls should be added to swsusp1, too. Can
someone verify that this fixes stuff? I should get some sleep...
Pavel
--- clean/kernel/power/disk.c 2004-10-01 00:30:32.000000000 +0200
+++ linux/kernel/power/disk.c 2004-10-29 00:30:40.000000000 +0200
@@ -102,6 +116,7 @@
static void finish(void)
{
+ sysdev_resume();
device_resume();
platform_finish();
enable_nonboot_cpus();
@@ -133,8 +148,12 @@
free_some_memory();
disable_nonboot_cpus();
- if ((error = device_suspend(PM_SUSPEND_DISK)))
+ if ((error = device_suspend(PM_SUSPEND_DISK))) {
+ printk("Some devices failed to suspend\n");
goto Finish;
+ }
+
+ sysdev_suspend(POWER_SUSPEND_DISK);
return 0;
Finish:
--- clean/kernel/power/swsusp.c 2004-10-19 14:16:29.000000000 +0200
+++ linux/kernel/power/swsusp.c 2004-10-29 00:32:26.000000000 +0200
@@ -825,6 +812,7 @@
int swsusp_write(void)
{
int error;
+ sysdev_resume();
device_resume();
lock_swapdevices();
error = write_suspend_image();
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-10-28 22:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-27 2:48 Fixing MTRR smp breakage and suspending sysdevs Li, Shaohua
2004-10-27 2:49 ` Nigel Cunningham
2004-10-27 3:20 ` Dmitry Torokhov
2004-10-27 3:17 ` Nigel Cunningham
2004-10-27 3:50 ` Dmitry Torokhov
2004-10-27 3:55 ` Nigel Cunningham
2004-10-27 10:00 ` Pavel Machek
2004-10-28 22:38 ` Pavel Machek [this message]
2004-10-29 0:18 ` time and suspending sysdevs [was Re: Fixing MTRR smp breakage and suspending sysdevs.] Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028223838.GA2319@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=ncunningham@linuxmail.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox