* [2.6 patch] i2c it87.c: remove an unused function
@ 2004-10-28 22:20 Adrian Bunk
2004-10-29 0:17 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2004-10-28 22:20 UTC (permalink / raw)
To: Chris Gauthron, greg, phil; +Cc: sensors, linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The patch below removes an unused function from drivers/i2c/chips/it87.c
diffstat output:
drivers/i2c/chips/it87.c | 7 -------
1 files changed, 7 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
- --- linux-2.6.10-rc1-mm1-full/drivers/i2c/chips/it87.c.old 2004-10-28 23:00:26.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/i2c/chips/it87.c 2004-10-28 23:00:37.000000000 +0200
@@ -56,13 +56,6 @@
#define PME 0x04 /* The device with the fan registers in it */
#define DEVID 0x20 /* Register: Device ID */
- -static inline void
- -superio_outb(int reg, int val)
- -{
- - outb(reg, REG);
- - outb(val, VAL);
- -}
- -
static inline int
superio_inb(int reg)
{
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFBgXC3mfzqmE8StAARAnheAJ4oIAZ/LT/MvhtbLjQpkCokdnkCzQCeMUx+
0hf83OAbIcIyj95pPV3hUWg=
=AgjG
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] i2c it87.c: remove an unused function
2004-10-28 22:20 [2.6 patch] i2c it87.c: remove an unused function Adrian Bunk
@ 2004-10-29 0:17 ` Adrian Bunk
2004-10-29 7:34 ` Jean Delvare
2004-11-05 21:47 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Adrian Bunk @ 2004-10-29 0:17 UTC (permalink / raw)
To: Chris Gauthron, greg, phil; +Cc: sensors, linux-kernel
[ this time without the problems due to a digital signature... ]
The patch below removes an unused function from drivers/i2c/chips/it87.c
diffstat output:
drivers/i2c/chips/it87.c | 7 -------
1 files changed, 7 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm1-full/drivers/i2c/chips/it87.c.old 2004-10-28 23:00:26.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/i2c/chips/it87.c 2004-10-28 23:00:37.000000000 +0200
@@ -56,13 +56,6 @@
#define PME 0x04 /* The device with the fan registers in it */
#define DEVID 0x20 /* Register: Device ID */
-static inline void
-superio_outb(int reg, int val)
-{
- outb(reg, REG);
- outb(val, VAL);
-}
-
static inline int
superio_inb(int reg)
{
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] i2c it87.c: remove an unused function
2004-10-29 0:17 ` Adrian Bunk
@ 2004-10-29 7:34 ` Jean Delvare
2004-11-05 21:47 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2004-10-29 7:34 UTC (permalink / raw)
To: bunk, chrisg, greg; +Cc: sensors, linux-kernel
Hi Adrian & all,
> The patch below removes an unused function from drivers/i2c/chips/it87.c
> (...)
> -static inline void
> -superio_outb(int reg, int val)
For information, this function was most likely there for the case we
would implement the force_addr module parameter for this driver (see the
w83627hf driver in the same directory for an example of that).
That said, I have no objection to the removal of this function. We can
still add it back later if we ever need it.
Thanks,
Jean
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] i2c it87.c: remove an unused function
2004-10-29 0:17 ` Adrian Bunk
2004-10-29 7:34 ` Jean Delvare
@ 2004-11-05 21:47 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2004-11-05 21:47 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Chris Gauthron, phil, sensors, linux-kernel
On Fri, Oct 29, 2004 at 02:17:45AM +0200, Adrian Bunk wrote:
> [ this time without the problems due to a digital signature... ]
>
> The patch below removes an unused function from drivers/i2c/chips/it87.c
>
>
> diffstat output:
> drivers/i2c/chips/it87.c | 7 -------
> 1 files changed, 7 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-11-05 21:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-28 22:20 [2.6 patch] i2c it87.c: remove an unused function Adrian Bunk
2004-10-29 0:17 ` Adrian Bunk
2004-10-29 7:34 ` Jean Delvare
2004-11-05 21:47 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).