public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Patrick Mochel <mochel@digitalimplant.org>
Subject: Re: [PATCH 2/4] Driver core: add driver_probe_device
Date: Fri, 29 Oct 2004 15:22:49 -0500	[thread overview]
Message-ID: <20041029202249.GB29171@kroah.com> (raw)
In-Reply-To: <20041029185753.53517.qmail@web81307.mail.yahoo.com>

On Fri, Oct 29, 2004 at 11:57:52AM -0700, Dmitry Torokhov wrote:
> > I really like the "driver" part in the device.  But not as a file, let's
> > make it a symlink back to the driver that is bound to the device at that
> > point in time.  This makes it just like the other symlinks in the sysfs
> > tree.
> > 
> > But if we do that, we still don't have a way to implement what you are
> > really trying to do (and it breaks your code as you already have a
> > driver file.)  I'll work on what I propose instead in my next message
> > (will be a few hours, have real work to do for a bit, sorry...)
> >
> 
> Well, we can have driver as a symlink and rename my "driver" attribute
> into something like "drvctl" (just an example, maybe somebody has better
> name in mind, I am not fixed on the name) and make it writable only.

Yes, that's exactly what I was thinking of.  But as you wanted it to do
three different things... Hm, no, I guess you only wanted it to do 2
things.  Ah, that's not bad at all.  Been traveling too long, can't
remember threads...

> I think it should work well as now device and driver objects are very
> symmetrical - they both similarly linked together via device->driver
> and driver->device).

I agree.  Hm, I guess the remaining 2 patches aren't that far away from
what I was thinking about originally. 

Ok, care to redo the "driver" patch to be a symlink instead?  I think
the last patch doesn't really need any changes, does it?

Hm, but how does this play with the current pci "add a new device id"
scheme?  Can this "bind_mode" scheme work with that?

thanks,

greg k-h

  reply	other threads:[~2004-10-29 20:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-29 18:57 [PATCH 2/4] Driver core: add driver_probe_device Dmitry Torokhov
2004-10-29 20:22 ` Greg KH [this message]
2004-10-30  8:26   ` Dmitry Torokhov
2004-10-30  8:27     ` [PATCH 1/4] Driver core: add driver symlink to device Dmitry Torokhov
2004-10-30  8:28       ` [PATCH 2/4] Driver core: add drvctl device attribute Dmitry Torokhov
2004-10-30  8:28         ` [PATCH 3/4] Driver core: add bind_mode device/driver attributes Dmitry Torokhov
2004-10-30  8:29           ` [PATCH 4/4] Driver core: bus_rescan_devices improper locking Dmitry Torokhov
2004-11-01 22:43       ` [PATCH 1/4] Driver core: add driver symlink to device Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2004-10-07  4:54 Driver core change request Dmitry Torokhov
2004-10-12  6:29 ` Dmitry Torokhov
2004-10-12  6:31   ` [PATCH 1/4] Driver core: export device_attach Dmitry Torokhov
2004-10-12  6:31     ` [PATCH 2/4] Driver core: add driver_probe_device Dmitry Torokhov
2004-10-29 16:37       ` Greg KH
2004-10-29 18:24         ` Dmitry Torokhov
2004-10-29 18:32           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041029202249.GB29171@kroah.com \
    --to=greg@kroah.com \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@digitalimplant.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox